-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: use_diagnostic_signs = true
no longer works due to a recent Neovim change (0.10+)
#369
Comments
Note that with neovim/neovim#26618, neovim/neovim#26193 is no longer a breaking change. Plugins should still migrate to the new configuration format, but there is no immediate need to do so. |
I have a neovim config only using the new way to define diagnostic signs, so I decided to fix this by myself. You can see my pr above. Feel free to checkout and give your feedback. |
Development on the main branch is EOL. Trouble has been rewritten and will be merged in main soon. This issue/feature either no longer exists or has been implemented on dev. For more info, see https://github.com/folke/trouble.nvim/tree/dev |
Dear @folke is it possible that it is not yet enabled on Thanks |
Trouble now always uses the configured Neovim diagnostic signs. |
Did you use |
No, could find that in the dev docs. In the lsp handlers I have |
Can you show me the exact table you pass to diagnostics config? |
Interestingly, everything works on but it fails on The table you asked for:
|
like I said, on So no |
Did you check docs and existing issues?
Neovim version (nvim -v)
NVIM v0.10.0-dev-1856+gf4f7e2946-dirty
Operating system/version
Gentoo Linux
Describe the bug
Due to a recent change in Neovim (neovim/neovim#26193 I believe), diagnostics signs are now configured differently.
As a result, trouble displays "E" ; "W" ; "H" ; "I" letters instead of respective configured signs, despite using
use_diagnostic_signs = true
.Steps To Reproduce
neovim/nvim-lspconfig
config::Trouble
Expected Behavior
trouble displays signs instead of letters
Repro
No response
The text was updated successfully, but these errors were encountered: