29d1bb8 broke "open_with_trouble" functionality

[bellini666]

Did you check docs and existing issues?

• I have read all the trouble.nvim docs
• I have searched the existing issues of trouble.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.11.0-dev-3317+ga9c89bcbf-Homebrew

Operating system/version

MacOS 14.5

Describe the bug

After upgrading to 29d1bb8, open_with_trouble from telescope is empty.

I tried older commits and that one is the first one presenting the issue.

Here is my trouble config for reference: https://github.com/bellini666/dotfiles/blob/master/vim/lua/plugins.lua#L78

Steps To Reproduce

1. Use the latest version in main with my config
2. Search something with trouble
3. Use open_with_trouble functionality

Expected Behavior

Results to appear on trouble

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/trouble.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

[bellini666]

Did not provide a MRE as I'm in a hurry here, but can do later in case the cause is not obvious

[folke]

Have you tried reading the trouble docs?
There's literally a section on Telescope in there....

[bellini666]

Have you tried reading the trouble docs? There's literally a section on Telescope in there....

Hey @folke ,

Sorry, I think in a hurry the issue was not properly explained.

I know how to open with telescope (using it exactly as documented) and I have been using it for ages. The specific commit I linked here broke it. If I revert to the commit before that it works fine.

I can make a video later showing what is happening, but in short trouble opens but the results appear empty

[b0ae989c]

Maybe related to commit 4eaaf9c

[bellini666]

Maybe related to commit 4eaaf9c

Not sure. I bisect the issue to the specific commit that I linked here.

Taking a quick look at it it doesn't make sense, but checking out the exact previous version, which does also contain that change you linked here, makes it still work fine (e.g. I'm using 13ad959 locally to continue working until I can take a better look)

[folke]

ok, sorry, didn't read that correctly.

Probably your deafult fold settings? I'll see to revert that commit and do it differently

[bellini666]

ok, sorry, didn't read that correctly.

Probably your deafult fold settings? I'll see to revert that commit and do it differently

Np 😊

And regarding default fold settings, not sure... I have vim.opt.foldenable = false in my options as I don't like folds.

Let me know if you want me to try something locally here. I'll also try some options and let you know if I discover anything...

[folke]

I think I was able to fix it. Would be great if you can confirm!

[bellini666]

I think I was able to fix it. Would be great if you can confirm!

Tested it, the error is still there :(

I don't know if this will be helpful, but this is a video of the issue happening:

Screen.Recording.2024-06-03.at.20.04.52.mov

This is a video of the same reproduction but forcing lazy to install 13ad959 (the commit before the broken one)

Screen.Recording.2024-06-03.at.20.05.22.mov

Let me know if that doesn't help and I'll try to create the MRE

[folke]

My bad, can you check again?

[bellini666]

My bad, can you check again?

Fixed now! :)

Thanks folke!