Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump to location broke on modified buffers #5

Closed
ii14 opened this issue Apr 23, 2021 · 2 comments
Closed

Jump to location broke on modified buffers #5

ii14 opened this issue Apr 23, 2021 · 2 comments

Comments

@ii14
Copy link
Contributor

ii14 commented Apr 23, 2021

When file is modified and I'm pressing Enter on a diagnostic to jump to it, it throws an error instead:

E5108: Error executing lua ...share/nvim/plugged/lsp-trouble.nvim/lua/trouble/view.lua:291: Vim(edit):E37: No write since last change (add ! to override)

https://github.com/folke/lsp-trouble.nvim/blob/b20a7844a035cf6795270db575ad8c4db2a774c9/lua/trouble/view.lua#L291
folke added a commit that referenced this issue Apr 23, 2021
@folke
fix: don't "edit" en existing buffer. Use "buffer" instead. (#5, #6)
abef115
@folke
Copy link
Owner

folke commented Apr 23, 2021

Damn, good catch!

I fixed an issue last night that introduced this.

Can you check if all works as expected now?

@ii14
Copy link
Contributor Author

ii14 commented Apr 23, 2021

Seems to work 👍

@ii14 ii14 closed this as completed Apr 23, 2021
@github-actions github-actions bot mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@folke @ii14