Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@folke maybe set opts.delay to timeoutlen by default to maintain previous behaviour? #697

Closed
folke opened this issue Jul 15, 2024 · 3 comments · Fixed by #688
Closed

@folke maybe set opts.delay to timeoutlen by default to maintain previous behaviour? #697

folke opened this issue Jul 15, 2024 · 3 comments · Fixed by #688

Comments

@folke
Copy link
Owner

folke commented Jul 15, 2024

          @folke maybe set `opts.delay` to `timeoutlen` by default to maintain previous behaviour?

Originally posted by @Rizhiy in #648 (comment)

@tigion
Copy link

tigion commented Jul 15, 2024

I currently have the following in my which-key config:

delay = function()
  -- NOTE: To make `<Leader>d` and `<Leader>dd` keymaps work
  --       make sure that opts.delay >= timeoutlen.
  --       - https://github.com/folke/which-key.nvim/issues/648#issuecomment-2226881346
  local delay = 200
  return delay < vim.o.timeoutlen and vim.o.timeoutlen or delay
end,

@folke
Copy link
Owner Author

folke commented Jul 15, 2024

I'll just fix it so that it always works regardless of timeoutlen / delay.

@folke folke closed this as completed in 80f20ee Jul 15, 2024
@folke
Copy link
Owner Author

folke commented Jul 15, 2024

I just pushed a change where which-key now honors nowait and timeoutlen the same as Neovim does,
regardless of timeoutlen or delay

folke pushed a commit that referenced this issue Jul 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.4.0](v3.3.0...v3.4.0)
(2024-07-15)


### Features

* added icons for function keys
([9222280](9222280))
* **mode:** allow certain modes to start hidden and only show after
keypress. See [#690](#690)
([b4fa48f](b4fa48f))
* **presets:** added gw
([09b80a6](09b80a6))
* **presets:** better padding defaults for helix preset
([4c36b9b](4c36b9b))
* **presets:** increase default height for helix
([df0ad20](df0ad20))
* simplified/documented/fixed mappings sorting. Closes
[#694](#694)
([eb73f7c](eb73f7c))
* **state:** skip mouse keys in debug
([5f85b77](5f85b77))
* **ui:** show keys/help in an overlay and added scrolling hint
([50b2c43](50b2c43))
* **view:** get parent icon if possible
([b9de927](b9de927))


### Bug Fixes

* **buf:** always detach " when executing keys. Fixes
[#689](#689)
([d36f722](d36f722))
* **config:** set expand=0 by default. Fixes
[#693](#693)
([89434aa](89434aa))
* **config:** warn when deprecated config options were used. Fixes
[#696](#696)
([81413ef](81413ef))
* **health:** move deprecated option check to health
([af7a30f](af7a30f))
* **mappings:** allow creating keymaps without desc. Fixes
[#695](#695)
([c442aaa](c442aaa))
* **plugins:** add existing keymaps to plugin view. Fixes
[#681](#681)
([26f6fd2](26f6fd2))
* **presets:** don't override title setting for classic. See
[#649](#649)
([9a53c1f](9a53c1f))
* **presets:** shorter descriptions
([20600e4](20600e4))
* **state:** always do full update on BufReadPost since buffer-local
keymaps would be deleted. Fixes
[#709](#709)
([6068887](6068887))
* **state:** don't show when coming from cmdline mode. Fixes
[#692](#692)
([8cba66b](8cba66b))
* **state:** honor timeoutlen and nowait. Fixes
[#648](#648). Closes
[#697](#697)
([80f20ee](80f20ee))
* **state:** properly disable which-key when recording macros. Fixes
[#702](#702)
([b506275](b506275))
* **state:** scrolling
([dce9167](dce9167))
* **tree:** rawget for existing plugin node children
([c77cda8](c77cda8))
* **util:** when no clipboard provider exists, use the " register as
default. Fixes
[#687](#687)
([d077a3f](d077a3f))
* **view:** disable footer on Neovim &lt; 0.10
([6d544a4](6d544a4))
* **view:** ensure highlights get set for title padding
([#684](#684))
([2e4f7af](2e4f7af))
* **view:** hide existing title/footer when no trail
([4f589a1](4f589a1))
* **view:** include group keymaps in expand results. See
[#682](https://github.com/folke/which-key.nvim/issues/682)
([39e703c](39e703c))
* **view:** overlap protection should keep at least 4 lines
([0d89475](0d89475))
* **view:** padding & column spacing. Fixes
[#704](#704)
([11eec49](11eec49))
* **view:** spacing when more than one box
([89568f3](89568f3))
* **view:** special handling of `&lt;NL&gt;/<C-J>`. Fixes
[#706](#706)
([f8c91b2](f8c91b2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants