Skip to content

Commit

Permalink
fix(build): upgrade css minify and remove specialcomments
Browse files Browse the repository at this point in the history
This PR upgrades gulp-clean-css (respectively clean-css) to the latest version.
Now the removement of special header comments in the concatenated minified css file semantic.min.css is properly done and works
Before, the minified concatenated css file still contained every special /*! ... */ header from each single .css file which increased the minified css file significantly.
  • Loading branch information
lubber-de authored Dec 24, 2020
1 parent d1b6dea commit 36c6aa0
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 22 deletions.
25 changes: 12 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"gulp": "^4.0.0",
"gulp-autoprefixer": "^6.0.0",
"gulp-chmod": "^2.0.0",
"gulp-clean-css": "^3.10.0",
"gulp-clean-css": "^4.3.0",
"gulp-clone": "^2.0.1",
"gulp-concat": "^2.6.1",
"gulp-concat-css": "^3.1.0",
Expand Down
19 changes: 11 additions & 8 deletions tasks/config/tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,11 @@ module.exports = {

/* Minified CSS Concat */
minify: {
processImport : false,
restructuring : false,
keepSpecialComments : 1,
roundingPrecision : -1,
level: {
1: {
inline : false
}
}
},

/* Minified JS Settings */
Expand All @@ -159,10 +160,12 @@ module.exports = {

/* Minified Concat CSS Settings */
concatMinify: {
processImport : false,
restructuring : false,
keepSpecialComments : false,
roundingPrecision : -1,
level: {
1: {
inline : false,
specialComments : false
}
}
},

/* Minified Concat JS */
Expand Down

0 comments on commit 36c6aa0

Please sign in to comment.