feat(chore): use modern "let" instead of "var" in build scripts

Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing no-var rule.

For src/* files it cannot be fixed (now) because of limited support in IE11.

.eslintrc.js

@@ -62,14 +62,14 @@ module.exports = {
         'prefer-destructuring': 'off',
         'prefer-template': 'off',
         'spaced-comment': ['error', 'always', {
-            line: {
-                markers: ['/'],
-                exceptions: ['-', '+'],
-            },
             block: {
-                markers: ['!'],
-                exceptions: ['*'],
                 balanced: true,
+                exceptions: ['*'],
+                markers: ['!'],
+            },
+            line: {
+                exceptions: ['-', '+'],
+                markers: ['/'],
             },
         }],
         strict: 'off',

gulpfile.js

@@ -2,7 +2,7 @@
  *           Set-up
  *******************************/
 
-var
+let
     gulp   = require('gulp'),
 
     // read user config to know what task to load

tasks/README.md

@@ -10,8 +10,6 @@
 These tasks can be imported into your own gulpfile allowing you to avoid using Semantic's build tools
 
 ```javascript
-var
-  watch = require('path/to/semantic/tasks/watch')
-;
+const watch = require('path/to/semantic/tasks/watch');
 gulp.task('watch ui', watch);
 ```

tasks/admin/components/create.js

@@ -14,7 +14,7 @@
   * create meteor.js file
 */
 
-var
+let
     gulp            = require('gulp'),
 
     // node dependencies
@@ -41,20 +41,20 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         stream,
         index,
         tasks = []
     ;
 
     for (index in release.components) {
-        var
+        let
             component = release.components[index]
     ;
 
         // streams... designed to save time and make coding fun...
         (function (component) {
-            var
+            let
                 outputDirectory      = path.join(release.outputRoot, component),
                 isJavascript         = fs.existsSync(output.compressed + component + '.js'),
                 isCSS                = fs.existsSync(output.compressed + component + '.css'),
@@ -266,7 +266,7 @@ module.exports = function (callback) {
 
             // Creates meteor package.js
             function createMeteorPackage() {
-                var
+                let
                     filenames = ''
                 ;
 

tasks/admin/components/init.js

@@ -12,7 +12,7 @@
 
 */
 
-var
+let
     gulp      = require('gulp'),
 
     // node dependencies
@@ -38,7 +38,7 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         index = -1,
         total = release.components.length,
         timer,
@@ -62,7 +62,7 @@ module.exports = function (callback) {
             return;
         }
 
-        var
+        let
             component            = release.components[index],
             outputDirectory      = path.resolve(release.outputRoot + component),
             capitalizedComponent = component.charAt(0).toUpperCase() + component.slice(1),

tasks/admin/components/update.js

@@ -12,7 +12,7 @@
 
 */
 
-var
+let
     gulp           = require('gulp'),
 
     // node dependencies
@@ -36,7 +36,7 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         index = -1,
         total = release.components.length,
         timer,
@@ -59,7 +59,7 @@ module.exports = function (callback) {
             return;
         }
 
-        var
+        let
             component            = release.components[index],
             outputDirectory      = path.resolve(path.join(release.outputRoot, component)),
             capitalizedComponent = component.charAt(0).toUpperCase() + component.slice(1),

tasks/admin/distributions/create.js

@@ -9,7 +9,7 @@
   * update package.json file
 */
 
-var
+let
     gulp            = require('gulp'),
 
     // node dependencies
@@ -35,20 +35,20 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         stream,
         index,
         tasks = []
     ;
 
     for (index in release.distributions) {
-        var
+        let
             distribution = release.distributions[index]
     ;
 
         // streams... designed to save time and make coding fun...
         (function (distribution) {
-            var
+            let
                 distLowerCase   = distribution.toLowerCase(),
                 outputDirectory = path.join(release.outputRoot, distLowerCase),
                 packageFile     = path.join(outputDirectory, release.files.npm),
@@ -87,7 +87,7 @@ module.exports = function (callback) {
                     files = []
                 ;
                 list.forEach(function (file) {
-                    var
+                    let
                         isOmitted = (omitted.indexOf(file) > -1),
                         filePath  = path.join(dir, file),
                         stat      = fs.statSync(filePath)
@@ -106,8 +106,8 @@ module.exports = function (callback) {
 
             // spaces out list correctly
             createList = function (files) {
-                var filenames = '';
-                for (var file in files) {
+                let filenames = '';
+                for (let file in files) {
                     if (file == (files.length - 1)) {
                         filenames += "'" + files[file] + "'";
                     } else {
@@ -119,7 +119,7 @@ module.exports = function (callback) {
             };
 
             tasks.push(function () {
-                var
+                let
                     files     = gatherFiles(outputDirectory),
                     filenames = createList(files)
                 ;
@@ -135,7 +135,7 @@ module.exports = function (callback) {
 
             if (distribution == 'CSS') {
                 tasks.push(function () {
-                    var
+                    let
                         themes,
                         components,
                         releases
@@ -154,7 +154,7 @@ module.exports = function (callback) {
                 });
             } else if (distribution == 'LESS') {
                 tasks.push(function () {
-                    var
+                    let
                         definitions,
                         themeImport,
                         themeConfig,

tasks/admin/distributions/init.js

@@ -12,7 +12,7 @@
 
 */
 
-var
+let
     gulp      = require('gulp'),
 
     // node dependencies
@@ -38,7 +38,7 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         index = -1,
         total = release.distributions.length,
         timer,
@@ -62,7 +62,7 @@ module.exports = function (callback) {
             return;
         }
 
-        var
+        let
             component          = release.distributions[index],
             lowerCaseComponent = component.toLowerCase(),
             outputDirectory    = path.resolve(release.outputRoot + lowerCaseComponent),

tasks/admin/distributions/update.js

@@ -12,7 +12,7 @@
 
 */
 
-var
+let
     gulp           = require('gulp'),
 
     // node dependencies
@@ -36,7 +36,7 @@ var
 ;
 
 module.exports = function (callback) {
-    var
+    let
         index = -1,
         total = release.distributions.length,
         timer,
@@ -59,7 +59,7 @@ module.exports = function (callback) {
             return;
         }
 
-        var
+        let
             distribution         = release.distributions[index],
             outputDirectory      = path.resolve(path.join(release.outputRoot, distribution.toLowerCase())),
             repoName             = release.distRepoRoot + distribution,

tasks/admin/publish.js

@@ -9,7 +9,7 @@
 
 */
 
-var
+let
     gulp = require('gulp')
 ;
 

tasks/admin/register.js

@@ -8,7 +8,7 @@
   * Registers component with NPM
 */
 
-var
+let
     // node dependencies
     process = require('child_process'),
 
@@ -35,7 +35,7 @@ module.exports = function (callback) {
 
             return;
         }
-        var
+        let
             repo            = repos[index].toLowerCase(),
             outputDirectory = release.outputRoot + repo + '/',
             exec            = process.exec,

tasks/admin/release.js

@@ -10,7 +10,7 @@
 
 */
 
-var
+let
     gulp = require('gulp')
 ;
 

tasks/build.js

@@ -2,7 +2,7 @@
  *         Build Task
  *******************************/
 
-var
+let
     // dependencies
     gulp     = require('gulp'),
 

tasks/build/assets.js

@@ -2,7 +2,7 @@
  Build Task
  *******************************/
 
-var
+let
     gulp      = require('gulp'),
 
     // gulp dependencies
@@ -42,7 +42,7 @@ function buildAssets(src, config, callback) {
     }
 
     // copy assets
-    var assets         = () => build(src, config);
+    let assets         = () => build(src, config);
     assets.displayName = 'Building Assets';
 
     gulp.series(assets)(callback);

tasks/check-install.js

@@ -2,7 +2,7 @@
  *        Check Install
  *******************************/
 
-var
+let
     // node dependencies
     gulp    = require('gulp'),
     console = require('better-console'),

tasks/clean.js

@@ -2,7 +2,7 @@
           Clean Task
 *******************************/
 
-var
+let
     del    = require('del'),
     config = require('./config/user'),
     tasks  = require('./config/tasks')

tasks/collections/README.md

@@ -4,11 +4,9 @@ These are collections of tasks that are imported together.
 
 To import them into gulp:
 ```javascript
-var
-  gulp    = require('gulp'),
-  // modified to point to semantic folder
-  install = require('tasks/collections/install')
-;
+const gulp = require('gulp');
+// modified to point to semantic folder
+const install = require('tasks/collections/install');
 gulp = install(gulp);
 
 // tasks are now injected and ready to be used

tasks/collections/admin.js

@@ -14,7 +14,7 @@
  *******************************/
 
 module.exports = function (gulp) {
-    var
+    let
         // less/css distributions
         initComponents      = require('../admin/components/init'),
         createComponents    = require('../admin/components/create'),

tasks/collections/docs.js

@@ -7,7 +7,7 @@
   https://github.com/Semantic-Org/Semantic-UI-Docs/
 */
 module.exports = function (gulp) {
-    var
+    let
         // docs tasks
         serveDocs = require('../docs/serve'),
         buildDocs = require('../docs/build')

tasks/collections/install.js

@@ -7,7 +7,7 @@
   https://github.com/Semantic-Org/Semantic-UI-Docs/
 */
 module.exports = function (gulp) {
-    var
+    let
         // docs tasks
         install      = require('../install'),
         checkInstall = require('../check-install')