Skip to content

Commit

Permalink
fix(sidebar): avoid scrollbar on non body pushable
Browse files Browse the repository at this point in the history
When a bottom sidebar was used inside non body pushable context, it was always added to the context divs height, making the vertical scrollbar appear. As the body will still provide a possible scrollbar it's save to remove the inner pushable vertical scrollbar.

Reason for the behavior is the 100% translate3d() setting to hide the sidebar which adds its content to the parent div. For left/right the overflow-x:hidden is already set and for top it's a negative position of -100%, so the change of overflow-y is not affected in the other cases.
  • Loading branch information
lubber-de authored Jul 31, 2020
1 parent 0e6526d commit c8ad8b9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/definitions/modules/sidebar.less
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ body.pushable {
/* Page Context */
.pushable:not(body) {
transform: translate3d(0, 0, 0);
overflow-y: hidden;
}
.pushable:not(body) > .ui.sidebar,
.pushable:not(body) > .fixed,
Expand Down

0 comments on commit c8ad8b9

Please sign in to comment.