fix(slider): also bind events on disabled variant

Always bind events even if the initial slider is disabled. This allows to keep the slider intact if the disabled class is removed manually
fomantic · Mar 2, 2023 · cb680cb · cb680cb
1 parent e275dcb
commit cb680cb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/definitions/modules/slider.js b/src/definitions/modules/slider.js
@@ -103,9 +103,7 @@
                     module.setup.layout();
                     module.setup.labels();
 
-                    if (!module.is.disabled()) {
-                        module.bind.events();
-                    }
+                    module.bind.events();
 
                     module.read.metadata();
                     module.read.settings();
@@ -401,6 +399,9 @@
                         }
                     },
                     keydown: function (event, first) {
+                        if (module.is.disabled()) {
+                            return;
+                        }
                         if (settings.preventCrossover && module.is.range() && module.thumbVal === module.secondThumbVal) {
                             $currThumb = undefined;
                         }
@@ -437,7 +438,7 @@
                         }
                     },
                     activateFocus: function (event) {
-                        if (!module.is.focused() && module.is.hover() && module.determine.keyMovement(event) !== NO_STEP) {
+                        if (!module.is.disabled() && !module.is.focused() && module.is.hover() && module.determine.keyMovement(event) !== NO_STEP) {
                             event.preventDefault();
                             module.event.keydown(event, true);
                             $module.trigger('focus');