Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): compile error of php less port #1833

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

cmoeke
Copy link
Contributor

@cmoeke cmoeke commented Jan 8, 2021

Description

Added semicolons after variable declarations

Closes

#1832

Fixed fomantic#1832 by adding semicolons after variable declarations
@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews type/bug Any issue which is a bug or PR which fixes a bug labels Jan 8, 2021
@lubber-de lubber-de added this to the 2.8.8 milestone Jan 8, 2021
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lubber-de lubber-de merged commit e058619 into fomantic:develop Jan 8, 2021
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 8, 2021
@lubber-de
Copy link
Member

@all-contributors please add @cmoeke for code

@allcontributors
Copy link
Contributor

@lubber-de

I've put up a pull request to add @cmoeke! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants