Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Range] implement SUI slider changes and more #290

Merged
merged 8 commits into from
Dec 20, 2018
Merged

[Range] implement SUI slider changes and more #290

merged 8 commits into from
Dec 20, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Dec 6, 2018

Description

This PR adds lot of features to the Range module, which is renamed to Slider for more consistency. It's based on many SUI's PRs, and some fixes of mine as well.

Here's what's new:

  • Range is now know as Slider.

  • Labeled silders:
    5bce0398ba0209fecf8af55e4f48579a.gif

  • Smooth or stepped slide:
    6f49ee69bd46562c7b2c5822be079ff5.gif

  • Undefined step:
    c45a3a4bd174e39acc3a10557a65c442.gif

  • Reversed display:
    c7eaa56bfca3760b75b5fb7f2888b1be.gif

  • Multisize:
    ed4c9028942be7efb312bfd37f12f54d.png

  • Keyboard controlled:
    51e2e24a0a876184df148ec13d784c51.gif

  • Basic and basic inverted modes: no demo because i'm not satisfied yet :)

  • Vertical ! ⚠️ Needs heavy testing ⚠️
    84eee40acc08887e5ab4dc3085ece6db.gif

  • Last but not least, a real range slider 🎉:
    42b6ab975eb397039eb9688310294d63.gif

And all of that features can be mixed up !

Closes

#117
#149
#150
Semantic-Org/Semantic-UI#1336

Thanks

@tyleryasaka, @gdaunton, @flytreeleft

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Dec 6, 2018
@prudho prudho added this to the 2.7.x milestone Dec 6, 2018
@prudho prudho self-assigned this Dec 6, 2018
y0hami
y0hami reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the dist files?

@y0hami y0hami modified the milestones: 2.7.x, 2.7.0 Dec 6, 2018
lubber-de
lubber-de reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 😎 This truly is an awesome PR. Great job @prudho 👍
I will test this at least by tomorrow

@lubber-de lubber-de added the tag/new-component New UI components label Dec 6, 2018
@prudho prudho force-pushed the range-clean branch 2 times, most recently from 1ef41b3 to 3f5a43e Compare December 6, 2018 10:35
@y0hami y0hami changed the title Range clean [Range] implement SUI slider changes and more Dec 6, 2018
@tyleryasaka
Copy link

Cool! 😄

@y0hami
Copy link
Member

y0hami commented Dec 7, 2018

Would it be a simple change to make it so the user can specify if they want the lines on the labeled slider something like labelPointer: true|false and default to false

@ColinFrick
Copy link
Member

Looks great! Will do some testing later today

@prudho
Copy link
Contributor Author

prudho commented Dec 10, 2018

Would it be a simple change to make it so the user can specify if they want the lines on the labeled slider something like labelPointer: true|false and default to false

I'd prefer name this option showLabelTicks: true|false if you don't mind, but yes, it's doable.

@y0hami
Copy link
Member

y0hami commented Dec 10, 2018

@prudho That name is fine with me 😃

@prudho
Copy link
Contributor Author

prudho commented Dec 10, 2018

Done !

y0hami
y0hami approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdaunton
Copy link
Contributor

This is a well oiled fork you all have here, glad the slider will get to live on as a part of it!

@tyleryasaka tyleryasaka mentioned this pull request Dec 16, 2018
Open
lubber-de
lubber-de approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great Job!

@y0hami y0hami merged commit d466262 into fomantic:develop Dec 20, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 20, 2018
@lubber-de lubber-de mentioned this pull request Dec 20, 2018
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Dec 20, 2018
This was referenced Dec 21, 2018
Merged
Merged
YamiOdymel added a commit to teacat/tocas that referenced this pull request Dec 22, 2018
@YamiOdymel
Changed Range back to Slider due to fomantic/Fomantic-UI#290
641a5b0
@prudho prudho deleted the range-clean branch April 11, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/new-component New UI components type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@prudho @tyleryasaka @y0hami @ColinFrick @bdaunton @lubber-de