Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): correct computing of gapRatio #3100

Closed
wants to merge 3 commits into from
Closed

fix(slider): correct computing of gapRatio #3100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68785fb
fix(slider): correct computing of gapRatio
Inselhopper Sep 24, 2024
9546361
Merge branch 'develop' into bugfix-slider-gapRatio
Inselhopper Sep 24, 2024
a28c5ea
Merge branch 'develop' into bugfix-slider-gapRatio
Inselhopper Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/definitions/modules/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,14 +765,12 @@
gapCounter = 1
;

// While the distance between two labels is too short,
// we divide the number of labels at each iteration
// and apply only if the modulo of the operation is an odd number.
// While the distance between two labels is too short for text at every label,
// we find out if we use only ticks with no text (gapRatio > 1)
// and apply text at any other tick (gapRatio = 2), any third tick (gapRatio = 3) and so on
if (trackLength > 0) {
while ((trackLength / numLabels) * gapCounter < settings.labelDistance) {
if (!(numLabels % gapCounter)) {
gapRatio = gapCounter;
}
gapRatio = gapCounter;
gapCounter += 1;
}
}
Expand Down