Send queued bond changes when last script finishes #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="js_init_set-empty-callback")
julia> using Pluto |
|
Pretty harmless PR because it's safe to call |
pankgeorg
added a commit
that referenced
this pull request
Feb 8, 2022
> Try this release in your browser! _(Available 30 minutes after the release)_ > > <a href="https://binder.plutojl.org/v0.18.0/"><img alt="Binder logo" src="https://mybinder.org/badge_logo.svg"></a> **Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!** [Diff since v0.17.7](v0.17.7...v0.18.0) **Merged pull requests:** - Make document currentscript work (#1765) (@dralletje) - don't count logs messages multiple times for pluto-logs width (#1843) (@Pangoraw) - Pattern matching system for lezer code (#1849) (@dralletje) - minor fix: Tables integration caused method ambiguation for Union{}[] (#1851) (@16bitmood) - Fix #1852, relocatable changes for sysimage usage. (#1853) (@MichaelHatherly) - Re-enable parseMixed (#1855) (@pankgeorg) - DOI in REAMDE for citation (#1864) (@rikhuijzer) - Use pkgdir instead of pathof (#1867) (@rikhuijzer) - Hide banner in CI (#1868) (@rikhuijzer) - Server-side events as configuration (#1871) (@ctrekker) - fix is_stdlib() for nightly and enable nightly tests (#1874) (@Pangoraw) - Awesome! Line wrapping! (#1876) (@dralletje) - respect maxlog keyword for logs, fixes #1858 (#1877) (@Pangoraw) - allow .. as an identifier, fixes #1875 (#1878) (@Pangoraw) - Server start event (#1882) (@ctrekker) - Julia 1.6 minimum (#1885) (@fonsp) - New heuristic to skip intermediate bond values (#1892) (@fonsp) - Send queued bond changes when last script finishes (#1898) (@fonsp) **Closed issues:** - Pkg.jl will corrupt itself on Windows (#671) - Failure creating JuMP DenseAxisArray (#806) - Frontend tests fail too often (#1234) - Open multiple notebooks at start and without browser (#1278) - Segmentation faults on Julia 1.7 M1 (#1722) - Table of content overlaps text in static HTML (#1770) - Pluto hangs when cell contains `(md" ", md"$t")` (#1800) - Cell drag drop broken in Linux Chrome v97 (#1809) - Tables integration causes method ambiguities for `pluto_showable` (#1815) - Segfault with CSV, SQLite, tables (M1) (#1842) - Use RelocatableFolders.jl instead of project_relative_dir to allow sysimages (#1852) - Logging doesn't respect `maxlog` (#1858) - TOC in dark mode is still light when aside (#1860) - ProgressLogging: suppressed logging in Turing.jl (#1862) - Cannot update to version 0.17.7 (#1869) - Stdlib packages marked as not found (#1872) - EllipsisNotation.jl (`randn((10,10))[1, ..]`) does not work (#1875) - Too many intermediate bond values (#1891)
![https://mybinder.org/badge_logo.svg"></a](https://mybinder.org/badge_logo.svg"></a){kind=link}
pankgeorg
added a commit
that referenced
this pull request
Feb 8, 2022
> Try this release in your browser! _(Available 30 minutes after the release)_ > > <a href="https://binder.plutojl.org/v0.18.0/"><img alt="Binder logo" src="https://mybinder.org/badge_logo.svg"></a> **Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!** [Diff since v0.17.7](v0.17.7...v0.18.0) **Merged pull requests:** - Make document currentscript work (#1765) (@dralletje) - don't count logs messages multiple times for pluto-logs width (#1843) (@Pangoraw) - Pattern matching system for lezer code (#1849) (@dralletje) - minor fix: Tables integration caused method ambiguation for Union{}[] (#1851) (@16bitmood) - Fix #1852, relocatable changes for sysimage usage. (#1853) (@MichaelHatherly) - Re-enable parseMixed (#1855) (@pankgeorg) - DOI in REAMDE for citation (#1864) (@rikhuijzer) - Use pkgdir instead of pathof (#1867) (@rikhuijzer) - Hide banner in CI (#1868) (@rikhuijzer) - Server-side events as configuration (#1871) (@ctrekker) - fix is_stdlib() for nightly and enable nightly tests (#1874) (@Pangoraw) - Awesome! Line wrapping! (#1876) (@dralletje) - respect maxlog keyword for logs, fixes #1858 (#1877) (@Pangoraw) - allow .. as an identifier, fixes #1875 (#1878) (@Pangoraw) - Server start event (#1882) (@ctrekker) - Julia 1.6 minimum (#1885) (@fonsp) - New heuristic to skip intermediate bond values (#1892) (@fonsp) - Send queued bond changes when last script finishes (#1898) (@fonsp) **Closed issues:** - Pkg.jl will corrupt itself on Windows (#671) - Failure creating JuMP DenseAxisArray (#806) - Frontend tests fail too often (#1234) - Open multiple notebooks at start and without browser (#1278) - Segmentation faults on Julia 1.7 M1 (#1722) - Table of content overlaps text in static HTML (#1770) - Pluto hangs when cell contains `(md" ", md"$t")` (#1800) - Cell drag drop broken in Linux Chrome v97 (#1809) - Tables integration causes method ambiguities for `pluto_showable` (#1815) - Segfault with CSV, SQLite, tables (M1) (#1842) - Use RelocatableFolders.jl instead of project_relative_dir to allow sysimages (#1852) - Logging doesn't respect `maxlog` (#1858) - TOC in dark mode is still light when aside (#1860) - ProgressLogging: suppressed logging in Turing.jl (#1862) - Cannot update to version 0.17.7 (#1869) - Stdlib packages marked as not found (#1872) - EllipsisNotation.jl (`randn((10,10))[1, ..]`) does not work (#1875) - Too many intermediate bond values (#1891)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1892 .
is_notebook_idle()checks (among other things) if no scripts are currently running. Queued bond updates are sent fromcomponentDidUpdatein Editor.js, ifis_notebook_idle()returnsfalse.This creates an edge case where an async script takes a little while to run, and by the time it finishes, bond updates have queued up, but there is nothing triggering
componentDidUpdateto send them. Bonds are then "stuck" until you interact with the notebook in another way (like typing somewhere).Solution
A callback that is fired when the last script is finished. On this callback, queued bond values are sent (if idle).