Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precompile statements to sessionactions #1977

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Mar 12, 2022

Co-Authored-By: Rik Huijzer 20724914+rikhuijzer@users.noreply.github.com

Split out from #1959

Co-Authored-By: Rik Huijzer <20724914+rikhuijzer@users.noreply.github.com>
@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="more-precompile-sessionactions")
julia> using Pluto

@fonsp
Copy link
Owner Author

fonsp commented Mar 12, 2022

Before: https://github.com/fonsp/Pluto.jl/runs/5521590989?check_suite_focus=true#step:4:1122
After: https://github.com/fonsp/Pluto.jl/runs/5521595334?check_suite_focus=true#step:4:1122

That's surprising, almost no difference in allocations? So I guess that #1934 already did most of the work.

But nice! It looks like we can really easily compare PRs now, thanks Rik!

@fonsp fonsp merged commit 0fe5c39 into main Mar 12, 2022
@rikhuijzer
Copy link
Collaborator

Before: https://github.com/fonsp/Pluto.jl/runs/5521590989?check_suite_focus=true#step:4:1122 After: https://github.com/fonsp/Pluto.jl/runs/5521595334?check_suite_focus=true#step:4:1122

That's surprising, almost no difference in allocations? So I guess that #1934 already did most of the work.

But nice! It looks like we can really easily compare PRs now, thanks Rik!

Yeah sorry. I commented in that different PR that the difference for me locally was 0.4 seconds. Not really much, but on the other hand they are basically for free. More gains for SessionActions.open require diving into what Core.Compiler.Timings.ROOT in typeinfer.jl:73 is doing (see the last image in #1934). I'm planning on diving into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants