Make published_to_js (now publish_to_js) official API through AbstractPlutoDingetjes.jl (v2)
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/disberd/Pluto.jl", rev="published_to_js")
julia> using Pluto |
disberd
changed the title
fonsp
changed the title
publish_to_js (now published_to_js) official API through AbstractPlutoDingetjes.jl (v2)
2 tasks
fonsp
changed the title
publish_to_js (now published_to_js) official API through AbstractPlutoDingetjes.jl (v2)published_to_js (now publish_to_js) official API through AbstractPlutoDingetjes.jl (v2)
|
Still missing is an |
|
I think I broke embed_display in #2607 so lets fix that here |
|
What is broken in embed_display? |
|
Yep looks like it still works! |
fonsp
approved these changes
Jul 20, 2023
This was referenced Aug 25, 2023
Merged
fonsp
added
backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrects #2162 and adds some front-end tests.
Second tests is currently commented out as it's broken due to #2092, but @fonsp had a very productive afternoon in Graz fixing that out in #2607
Works in combination with JuliaPluto/AbstractPlutoDingetjes.jl#11