Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack trace URL improvements #3038

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Stack trace URL improvements #3038

wants to merge 5 commits into from

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Oct 2, 2024 •
edited
Loading

New features:

  • Clickable URLs for functions from packages (thanks to @adrhill !!)
  • Show package name for external functions
  • Icon to show that the link will open in a new tab
  • Some CSS tweaks

Example

image

Example

image

fonsp and others added 3 commits October 2, 2024 14:12
@fonsp fonsp added the frontend Concerning the HTML editor label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="stack-frame-url-imrpvoements")
julia> using Pluto

@adrhill adrhill mentioned this pull request Oct 2, 2024
Open
@fonsp
Copy link
Owner Author

fonsp commented Oct 2, 2024

The new URL code does not work on Julia 1.6, and I don't see an easy way to make it work :(

@fonsp
Copy link
Owner Author

fonsp commented Oct 2, 2024 •
edited
Loading

It might be worth trying this code JuliaLang/julia#47709 (comment) ? RegistryInstances might be okay to add as a dep

@fonsp fonsp mentioned this pull request Oct 2, 2024
Merged
@fonsp fonsp added the error display How errors and stack traces are presented label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
error display How errors and stack traces are presented frontend Concerning the HTML editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fonsp