Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAT check summary #3248

Open
m4rc1e opened this issue Apr 22, 2021 · 3 comments
Open

STAT check summary #3248

m4rc1e opened this issue Apr 22, 2021 · 3 comments
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 22, 2021

In pr google/fonts#3304, @thlinard pointed out that the "Regular" axisValue must be elided.

For generating STAT tables, I make every axisValue which is a default in our Axis Registry elided, apart from the opsz axis. This seems to work nicely since it will correctly elide "Normal" (width), "Roman" (italic), "Default" (slant), "Proportional" (monospace) etc.

@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Apr 30, 2021
@RosaWagner
Copy link
Contributor

RosaWagner commented May 12, 2021

This would be really helpful to have that check

This is linked to to-do list for STAT table check: #3090 (comment)

  • Default value are elided (Regular, Roman, Normal etc.) (<Flags value="2"/>)
  • There is style linking between bold and Regular ( <LinkedValue value="700"/> in Regular)
  • There is style linking between Roman and Italic ( <LinkedValue value="1.0"/> in Roman)
  • There is a weight instance every 100 and is consistent with FVAR

These check allow a proper support of STAT table from different app, ie. to display instances' names correctly in drop down menu, and to allow proper linking of RIBBI styles.

Right now, checking for these 3 things force us to dump the STAT table, or check in Samsa.

@davelab6
Copy link
Contributor

Seems urgent! :)

@thlinard
Copy link

thlinard commented May 13, 2021

apart from the opsz axis

Elided default opsz value is much more elegant in applications with only named instances support (MS Office for Mac, Apple apps…).

Newsreader and Texturina have <Flags value = "2" /> on their default opsz value. See google/fonts#3267

@RosaWagner RosaWagner added Severity 5 (Highest) Font problems that must be addressed urgently! and removed Severity 5 (Highest) Font problems that must be addressed urgently! labels Jun 1, 2021
@RosaWagner RosaWagner changed the title Ensure that certain AxisValues are elided STAT check summary Jun 2, 2021
@felipesanches felipesanches added this to the 0.8.4 milestone Oct 14, 2021
@felipesanches felipesanches modified the milestones: 0.8.4, 0.8.8 Nov 19, 2021
@felipesanches felipesanches modified the milestones: 0.8.8, 0.8.9 Mar 14, 2022
@felipesanches felipesanches modified the milestones: 0.8.9, 0.8.10 Jun 10, 2022
@felipesanches felipesanches modified the milestones: 0.8.10, 0.8.17 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent
Projects
None yet
Development

No branches or pull requests

5 participants