Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check 069 #1822

Closed
wants to merge 1 commit into from
Closed

Remove check 069 #1822

wants to merge 1 commit into from

Conversation

madig
Copy link
Contributor

@madig madig commented Apr 23, 2018

Fonttools runs some sanitization on load that catches wrongly set up loca tables and matches them to the glyf table.

#1821

Fonttools runs some sanitization on load that catches wrongly set up loca tables
and matches them to the glyf table.
@felipesanches
Copy link
Collaborator

felipesanches commented Apr 23, 2018

I'd like to consider actually implementing this here, since someday we might want to get rid of third-party linters such as msfontval and fontforge. (see #1814 and #1541)

Would it be possible to detect the problem or does fonttools silently fix the problem on load with no chance of the user being noticed about it?

@madig
Copy link
Contributor Author

madig commented Apr 24, 2018

In all actuality, the sanitization is gone and ft logs errors when trying to access loca and glyf. Huh. On it.

@madig
Copy link
Contributor Author

madig commented Apr 24, 2018

Ok, it's still there but doesn't trigger due to lazy loading if you modify stuff and save the file before accessing certain tables.

@madig madig closed this Apr 24, 2018
@madig madig deleted the remove-069 branch May 11, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants