Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc optional Glyphs app compatibility formatting options #37

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

justvanrossum
Copy link
Contributor

@justvanrossum justvanrossum commented Jan 30, 2025

  • with single_line_tuples: don't output a space after a comma. This change is tied to single_line_tuples and is not backwards compatible.
  • single_line_empty_objects: this is kindof the opposite of single_line_tuples, in that it causes empty objects ({} and []) to be formatted over two lines. Default true.
  • binary_spaces: add/don't add grouping spaces for binary (hex) data (default true)

This fixes #36.

@justvanrossum
Copy link
Contributor Author

Hm, that test failure: did I cause that? I'm not sure I understand the error.

@anthrotype
Copy link
Member

anthrotype commented Jan 30, 2025

single_line_empty_objects... Default false.

you meant, default true (as in by default we keep serializing empty objects on a single line, unless single_line_empty_objects=False)

Hm, that test failure: did I cause that? I'm not sure I understand the error.

this is the same as this: pypa/cibuildwheel#598 (comment)
The immediate fix is to do this:

fonttools/fonttools@8abe2ae

Another better way to fix (possibly in a follow up PR if ever) is to completely avoid using docker/qemu for linux aarch64 and use the new, faster, Github-hosted Linux arm64 runners like I did in fonttools

fonttools/fonttools@cdf5a6e

Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justvanrossum
Copy link
Contributor Author

you meant, default true (as in by default we keep serializing empty objects on a single line, unless single_line_empty_objects=False)

Ah yes, sorry, fixed the description.

@justvanrossum
Copy link
Contributor Author

Another better way to fix (possibly in a follow up PR if ever) is to completely avoid using docker/qemu for linux aarch64 and use the new, faster, Github-hosted Linmux arm64 runners like I did in fonttools

For now I applied your earlier workaround. The better change looks much nicer, though, I'll gladly PR that afterwards.

@anthrotype anthrotype merged commit 6a9722a into fonttools:master Jan 30, 2025
10 checks passed
@justvanrossum justvanrossum deleted the glyphsapp-compat branch January 30, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_line_tuples: space after comma?
2 participants