-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc optional Glyphs app compatibility formatting options #37
Conversation
Hm, that test failure: did I cause that? I'm not sure I understand the error. |
you meant, default true (as in by default we keep serializing empty objects on a single line, unless single_line_empty_objects=False)
this is the same as this: pypa/cibuildwheel#598 (comment) Another better way to fix (possibly in a follow up PR if ever) is to completely avoid using docker/qemu for linux aarch64 and use the new, faster, Github-hosted Linux arm64 runners like I did in fonttools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah yes, sorry, fixed the description. |
For now I applied your earlier workaround. The better change looks much nicer, though, I'll gladly PR that afterwards. |
single_line_tuples
: don't output a space after a comma. This change is tied tosingle_line_tuples
and is not backwards compatible.single_line_empty_objects
: this is kindof the opposite of single_line_tuples, in that it causes empty objects ({}
and[]
) to be formatted over two lines. Default true.binary_spaces
: add/don't add grouping spaces for binary (hex) data (default true)This fixes #36.