-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Allow to use the host network #69
Comments
Thanks for raising this issue @dlehmhus. Your theory makes a lot of sense to me. Let me see what I can do. |
@dlehmhus - I'm having difficulty in coming up with a way to reproduce this. Can you provide an example? |
Hey @adamhenson, here is an example repo. It is basic create-next-app boilerplate with two feature branches, one that adds v5 and one that adds v6. |
Perfect, thanks @dlehmhus. I'll do some experimenting on my end. At the moment, I'm not sure if it's possible to use |
@dlehmhus - I'm not so sure we can support this. I haven't found a way. I tried passing
So, it doesn't actually pass the arg to Here's the PR I've been using for experimenting. Feel free to fork it and play around. Otherwise, I'm open to suggestions. I was looking for a way to do this in the I've spent most of my day working on this, and I think I've exhausted most of the time I'm willing to spend on this. Definitely open to suggestions. |
The reason for converting this project to Docker was mainly because GitHub took forever in providing a Node.js runner later than 12. I was starting to doubt it would ever happen. But, it looks like there was a recent comment on that issue and it appears that they've released a Node 16 runner. I'm not so sure the runner is available, but it appears that corresponding PR has been merged: actions/runner#1439 I think my next step will be to confirm if Node 16 runner is actually available and then I can convert this project back to it. Perhaps we could hold on this until then. |
Okay, the rumors are true. Node 16 runner is now available 😅 This PR should fix this issue once it's merged and released... hopefully within the next couple hours: #71 |
Feature request
Problem
In my current setup I'm running the lighthouse-check-action against a local server (e.g.
localhost:3000
). This worked fine with v5, but since v6 all tests always score 0 points. My explanation for this is, that v6 now runs inside a docker container, and therefore by default can not access the host's network.Request
Config to customize the docker container or add
--network="host"
by default.The text was updated successfully, but these errors were encountered: