-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Node.js 14 and 16 LTS as the runtime of JavaScript action #772
Comments
Looks like this is not easy 😭 runner/src/Runner.Worker/ActionManifestManager.cs Lines 454 to 471 in 89a13db
|
Is it done via actions/runner-images#1953 ? |
No. This is a problem of the actions/runner. peaceiris/actions-gh-pages#539
|
We need:
|
This action requires Node.js 14, but Node.js 12 is the currently-supported version. Related: actions/runner#772
This action requires Node.js 14, but Node.js 12 is the currently-supported version. Related: actions/runner#772
Hello, Thank you, |
@TingluoHuang I started working on this but I don't have any significant experience with C# so any help or direction would be much appreciated. |
Should we just wait for node.js 16 to become LTS and then directly goes to node 16? I don't see too many benefits that go to node 14. |
"Active LTS Start: 2021-10-26" not that far away 👍🏻 |
... we could even start much sooner with |
What would be the benefit of supporting node 14? Any features that would be unlocked by using it? |
Node16 support added last month: actions/runner#772 (comment)
According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772
According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772
According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772
* Update Node.js from v12 to v16 According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772 * prepare-for-release wiht node 16 * Node16 in Github actions * Attempt to use node16 in package.json
According to the release policy of Node.js, Node.js v12 reached EOL (end-of-life). https://nodejs.org/en/about/releases/ I think ruby/setup-ruby is ready to update Node.js to v16 because GitHub Actions runners support v16. actions/runner#772 (cherry picked from commit e92b797)
nodejs 16 supported by runner version 2.285.0 actions/runner#772
nodejs 16 supported by runner version 2.285.0 actions/runner#772
nodejs 16 supported by runner version 2.285.0 actions/runner#772
nodejs 16 supported by runner version 2.285.0 actions/runner#772
nodejs 16 supported by runner version 2.285.0 actions/runner#772
Describe the enhancement
Node.js v14.15.0 has been released and the 14.x release line now moves into Active LTS. Can the GitHub Actions runner support it as the runtime of a JavaScript (TypeScript) action? Is there a roadmap for this?
Code Snippet
Today, we can set
node12
toruns.using
.Can we set
node14
(ornode16
) as follows?Additional information
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions
We also need to update the documentation when
node14
is available.The text was updated successfully, but these errors were encountered: