chore: change access_token to optional
#72
Conversation
| @@ -15,10 +15,10 @@ inputs: | |||
| access_token: | |||
| description: 'Your GitHub Access Token, defaults to: {{ github.token }}' | |||
| default: '${{ github.token }}' | |||
| required: true | |||
| required: false | |||
There was a problem hiding this comment.
It has a default value
There was a problem hiding this comment.
What about the required prop in index.ts?
cancel-workflow-action/src/index.ts
Line 33 in cd25b7a
There was a problem hiding this comment.
@styfle Should it be deleted?
There was a problem hiding this comment.
I'm not sure. Are either of these required props causing problems?
There was a problem hiding this comment.
They're not causing any problems to me, but I saw it's set to required although it has a default value so that's why I created this PR
There was a problem hiding this comment.
If its not causing problems, lets not change it 🙂
There was a problem hiding this comment.
I would argue that it also implies that the docs can be simplified, if this works without passing the default.
|
@styfle Is there anything I can do to get this one merged? |
|
@styfle This is valuable PR since it simplifies action usage. Please consider merging it. |
styfle
changed the title
action.ymlaccess_token to optional
No description provided.