Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js from v12 to v16 #332

Merged
merged 1 commit into from
May 10, 2022
Merged

Update Node.js from v12 to v16 #332

merged 1 commit into from
May 10, 2022

Conversation

yykamei
Copy link
Contributor

@yykamei yykamei commented May 10, 2022

According to the release policy of Node.js,
Node.js v12 reached EOL (end-of-life).

https://nodejs.org/en/about/releases/

I think ruby/setup-ruby is ready to update Node.js to v16
because GitHub Actions runners support v16.

actions/runner#772

According to the release policy of Node.js,
Node.js v12 reached EOL (end-of-life).

https://nodejs.org/en/about/releases/

I think ruby/setup-ruby is ready to update Node.js to v16
because GitHub Actions runners support v16.

actions/runner#772
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit e92b797 into ruby:master May 10, 2022
@chenrui333
Copy link
Contributor

I am a bit surprised that this did not come as a major release (there are incompatibility with this change) Any thoughts?

@eregon
Copy link
Member

eregon commented Jul 11, 2022

IMHO it's too much to ask every user to bump a major version just for a dependency (node) which is anyway provided by the GitHub Actions runner software/its dependencies: #302 (comment)
I don't think it's reasonable to expect to be able to run recent actions with an old runner, is it?

@MSP-Greg
Copy link
Collaborator

Note that the Ubuntu-22.04 image only has node 14 & 16 installed.

@ShockwaveNN
Copy link

ShockwaveNN commented Jul 11, 2022

Note that the Ubuntu-22.04 image only has node 14 & 16 installed.

I've taken a look and Ubuntu 18.04, Ubuntu 20.04, Ubuntu 22.04, all macOS and latest Windows images have nodejs v16 installed by default according to README

So not sure about that incompatibility @chenrui333 talking about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants