This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Stop using CSS.supports for CSS property tests #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead generate both forms for the document.body.style tests where appropriate, to deal with odd -apple- and -epub-prefixed properties. Fixes #12.
|
Looking at the test results before and after this change, the false positives in Safari like That seems like a similar issue to the Safari false positives. I'll file a Gecko bug. |
|
I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1708384 and will merge this now, all the changes that I can see are improvements now. |
foolip
added a commit
that referenced
this pull request
May 8, 2021
#1132 has changed all CSS property tests, the the minor version is bumped. Added tests: api.AnimationEffect.after api.AnimationEffect.before api.AnimationEffect.nextSibling api.AnimationEffect.parent api.AnimationEffect.previousSibling api.AnimationEffect.remove api.AnimationEffect.replace api.AnimationNodeList api.AnimationNodeList.item api.AnimationNodeList.length api.AnimationTimeline.play api.AudioData api.AudioData.AudioData api.AudioData.allocationSize api.AudioData.clone api.AudioData.close api.AudioData.copyTo api.AudioData.duration api.AudioData.numberOfChannels api.AudioData.numberOfFrames api.AudioData.sampleFormat api.AudioData.sampleRate api.AudioData.timestamp api.CanvasRenderingContext2D.fontKerning api.CanvasRenderingContext2D.fontStretch api.CanvasRenderingContext2D.fontVariantCaps api.CanvasRenderingContext2D.reset api.CanvasRenderingContext2D.textLetterSpacing api.CanvasRenderingContext2D.textRendering api.CanvasRenderingContext2D.textWordSpacing api.GPUCompilationMessage.length api.GPUCompilationMessage.offset api.GPUQueue.copyExternalImageToTexture api.GroupEffect api.GroupEffect.GroupEffect api.GroupEffect.append api.GroupEffect.children api.GroupEffect.clone api.GroupEffect.firstChild api.GroupEffect.lastChild api.GroupEffect.prepend api.ImageData.colorSpace api.ImageDecoder api.ImageDecoder.ImageDecoder api.ImageDecoder.close api.ImageDecoder.complete api.ImageDecoder.completed api.ImageDecoder.decode api.ImageDecoder.isTypeSupported api.ImageDecoder.reset api.ImageDecoder.tracks api.ImageTrack api.ImageTrack.animated api.ImageTrack.frameCount api.ImageTrack.onchange api.ImageTrack.repetitionCount api.ImageTrack.selected api.ImageTrackList api.ImageTrackList.length api.ImageTrackList.ready api.ImageTrackList.selectedIndex api.ImageTrackList.selectedTrack api.MediaSession.setCameraActive api.MediaSession.setMicrophoneActive api.Navigator.devicePosture api.NavigatorUAData.toJSON api.OffscreenCanvasRenderingContext2D.fontKerning api.OffscreenCanvasRenderingContext2D.fontStretch api.OffscreenCanvasRenderingContext2D.fontVariantCaps api.OffscreenCanvasRenderingContext2D.reset api.OffscreenCanvasRenderingContext2D.textLetterSpacing api.OffscreenCanvasRenderingContext2D.textRendering api.OffscreenCanvasRenderingContext2D.textWordSpacing api.PaintRenderingContext2D.reset api.Sanitizer.config api.Sanitizer.defaultConfig api.Scheduler api.Scheduler.postTask api.SequenceEffect api.SequenceEffect.SequenceEffect api.SequenceEffect.clone api.TaskController api.TaskController.TaskController api.TaskController.setPriority api.TaskPriorityChangeEvent api.TaskPriorityChangeEvent.TaskPriorityChangeEvent api.TaskPriorityChangeEvent.previousPriority api.TaskSignal api.TaskSignal.onprioritychange api.TaskSignal.priority api.VideoFrame.close api.Window.scheduler api.WorkerGlobalScope.scheduler Removed tests: api.AudioFrame api.AudioFrame.AudioFrame api.AudioFrame.buffer api.AudioFrame.close api.AudioFrame.timestamp api.GPUQueue.copyImageBitmapToTexture api.Screen.posture api.VideoFrame.createImageBitmap api.VideoFrame.destroy
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead generate both forms for the document.body.style tests where
appropriate, to deal with odd -apple- and -epub-prefixed properties.
Fixes #12.