Add symbols back to the build to fix Dynatrace support (hashicorp#20294)

fopina · Apr 21, 2023 · 33cd7f4 · 33cd7f4
1 parent 7baf241
commit 33cd7f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/changelog/20294.txt b/changelog/20294.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+Add debug symbols back to builds to fix Dynatrace support
+```
diff --git a/scripts/ci-helper.sh b/scripts/ci-helper.sh
@@ -159,9 +159,10 @@ function build() {
   # Build our ldflags
   msg="--> Building Vault v$version, revision $revision, built $build_date"
 
-  # Strip the symbol and dwarf information by default
+  # Keep the symbol and dwarf information by default
+  # TODO: maybe add REMOVE_SYMBOLS?
   if [ -n "$KEEP_SYMBOLS" ]; then
-    ldflags=""
+    ldflags="-s -w "
   else
     ldflags="-s -w "
   fi