UI: add info banner for not parsable certs (hashicorp#20518)

* remove undefined payload.issuer_id

* add info banner to parsed display view

* add tests

* clean up conditional, add specific banner test selector

* check for undefined length

ui/app/serializers/pki/issuer.js

@@ -24,7 +24,6 @@ export default class PkiIssuerSerializer extends ApplicationSerializer {
       // Parse certificate back from the API and add to payload
       const parsedCert = parseCertificate(payload.data.certificate);
       const data = {
-        issuer_ref: payload.issuer_id,
         ...payload.data,
         parsed_certificate: parsedCert,
         common_name: parsedCert.common_name,

ui/lib/pki/addon/components/parsed-certificate-info-rows.hbs

@@ -6,4 +6,17 @@
       @formatDate={{field.formatDate}}
     />
   {{/let}}
-{{/each}}
+{{/each}}
+{{#if (or (eq @model.can_parse false) this.parsingErrors)}}
+  <AlertBanner
+    data-test-parsing-error-alert-banner
+    class="has-top-margin-m"
+    @type="info"
+    @title="There was an error parsing certificate metadata"
+  >
+    Vault cannot display unparsed values, but this will not interfere with the certificate's functionality.
+    {{#if this.parsingErrors}}
+      <p class="sub-text is-font-mono">Parsing error(s): {{this.parsingErrors}} </p>
+    {{/if}}
+  </AlertBanner>
+{{/if}}

ui/lib/pki/addon/components/parsed-certificate-info-rows.js

@@ -38,4 +38,11 @@ export default class ParsedCertificateInfoRowsComponent extends Component {
       };
     });
   }
+
+  get parsingErrors() {
+    if (this.args.model?.parsing_errors?.length) {
+      return this.args.model.parsing_errors.map((e) => e.message).join(', ');
+    }
+    return '';
+  }
 }

ui/tests/integration/components/pki/parsed-certificate-info-rows-test.js

@@ -3,6 +3,8 @@ import { setupRenderingTest } from 'vault/tests/helpers';
 import { render } from '@ember/test-helpers';
 import { hbs } from 'ember-cli-htmlbars';
 import { setupEngine } from 'ember-engines/test-support';
+import { parseCertificate } from 'vault/utils/parse-pki-cert';
+import { unsupportedOids } from 'vault/tests/helpers/pki/values';
 
 module('Integration | Component | parsed-certificate-info-rows', function (hooks) {
   setupRenderingTest(hooks);
@@ -36,5 +38,56 @@ module('Integration | Component | parsed-certificate-info-rows', function (hooks
     assert.dom('[data-test-row-value="Subject Alternative Names (SANs)"]').hasText('something,here');
     assert.dom('[data-test-value-div="Use PSS"]').hasText('No', 'Booleans are rendered');
     assert.dom('[data-test-value-div="ttl"]').doesNotExist('ttl is not rendered because value undefined');
+    assert
+      .dom('[data-test-parsing-error-alert-banner]')
+      .doesNotExist('does not render parsing error info banner');
+  });
+
+  test('it renders info banner when parsing fails and no parsing errors', async function (assert) {
+    this.set('parsedCertificate', {
+      can_parse: false,
+    });
+    await render(hbs`<ParsedCertificateInfoRows @model={{this.parsedCertificate}} />`, {
+      owner: this.engine,
+    });
+
+    assert
+      .dom('[data-test-parsing-error-alert-banner]')
+      .hasText(
+        "There was an error parsing certificate metadata Vault cannot display unparsed values, but this will not interfere with the certificate's functionality."
+      );
+  });
+
+  test('it renders info banner when parsing fails and parsing errors exist', async function (assert) {
+    this.set('parsedCertificate', {
+      can_parse: false,
+      parsing_errors: [new Error('some parsing error')],
+    });
+    await render(hbs`<ParsedCertificateInfoRows @model={{this.parsedCertificate}} />`, {
+      owner: this.engine,
+    });
+
+    assert
+      .dom('[data-test-parsing-error-alert-banner]')
+      .hasText(
+        "There was an error parsing certificate metadata Vault cannot display unparsed values, but this will not interfere with the certificate's functionality. Parsing error(s): some parsing error"
+      );
+  });
+
+  test('it renders info banner when parsing is successful but unsupported OIDs return parsing errors', async function (assert) {
+    const { parsing_errors } = parseCertificate(unsupportedOids);
+    this.set('parsedCertificate', {
+      can_parse: true,
+      parsing_errors,
+    });
+    await render(hbs`<ParsedCertificateInfoRows @model={{this.parsedCertificate}} />`, {
+      owner: this.engine,
+    });
+
+    assert
+      .dom('[data-test-parsing-error-alert-banner]')
+      .hasText(
+        "There was an error parsing certificate metadata Vault cannot display unparsed values, but this will not interfere with the certificate's functionality. Parsing error(s): certificate contains unsupported subject OIDs: 1.2.840.113549.1.9.1, certificate contains unsupported extension OIDs: 2.5.29.37"
+      );
   });
 });