Skip to content

Commit

Permalink
UI: Remove custom service (hashicorp#19925)
Browse files Browse the repository at this point in the history
  • Loading branch information
hashishaw committed Mar 31, 2023
1 parent 1239875 commit b04751d
Show file tree
Hide file tree
Showing 20 changed files with 30 additions and 33 deletions.
8 changes: 3 additions & 5 deletions ui/app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ export default class App extends Application {
engines = {
openApiExplorer: {
dependencies: {
services: ['auth', 'flash-messages', 'namespace', 'router', 'version'],
services: ['auth', 'namespace', 'router', 'version'],
},
},
replication: {
dependencies: {
services: ['auth', 'flash-messages', 'namespace', 'replication-mode', 'router', 'store', 'version'],
services: ['auth', 'namespace', 'replication-mode', 'router', 'store', 'version'],
externalRoutes: {
replication: 'vault.cluster.replication.index',
},
Expand All @@ -31,7 +31,6 @@ export default class App extends Application {
services: [
'auth',
'download',
'flash-messages',
'namespace',
'path-help',
'router',
Expand All @@ -46,7 +45,7 @@ export default class App extends Application {
},
kubernetes: {
dependencies: {
services: ['router', 'store', 'secret-mount-path', 'flashMessages'],
services: ['router', 'store', 'secret-mount-path'],
externalRoutes: {
secrets: 'vault.cluster.secrets.backends',
},
Expand All @@ -57,7 +56,6 @@ export default class App extends Application {
services: [
'auth',
'download',
'flash-messages',
'namespace',
'path-help',
'router',
Expand Down
5 changes: 4 additions & 1 deletion ui/app/components/transform-role-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ export default TransformBase.extend({
message =
'This role was edited to remove transformations, but this role was not removed from those transformations’ allowed_roles due to a lack of permissions.';
}
this.flashMessages.stickyInfo(message);
this.flashMessages.info(message, {
sticky: true,
priority: 300,
});
}
});
},
Expand Down
5 changes: 4 additions & 1 deletion ui/app/components/transformation-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ export default TransformBase.extend({
// eg. trying to update a role with empty array as transformations
message = `You've edited the allowed_roles for this transformation. However, the corresponding edits to some roles' transformations were not made`;
}
this.flashMessages.stickyInfo(message);
this.flashMessages.info(message, {
sticky: true,
priority: 300,
});
}
});
},
Expand Down
5 changes: 4 additions & 1 deletion ui/app/routes/vault/cluster/auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ export default ClusterRouteBase.extend({

afterModel() {
if (config.welcomeMessage) {
this.flashMessages.stickyInfo(config.welcomeMessage);
this.flashMessages.info(config.welcomeMessage, {
sticky: true,
priority: 300,
});
}
},
});
15 changes: 0 additions & 15 deletions ui/app/services/flash-messages.ts

This file was deleted.

1 change: 1 addition & 0 deletions ui/lib/kmip/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
],
"dependencies": {
"ember-cli-htmlbars": "*",
"ember-cli-flash": "*",
"ember-cli-babel": "*"
},
"ember-addon": {
Expand Down
1 change: 1 addition & 0 deletions ui/lib/kubernetes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dependencies": {
"ember-cli-htmlbars": "*",
"ember-cli-babel": "*",
"ember-cli-flash": "*",
"ember-concurrency": "*",
"@ember/test-waiters": "*",
"ember-inflector": "*"
Expand Down
1 change: 1 addition & 0 deletions ui/lib/open-api-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dependencies": {
"ember-cli-htmlbars": "*",
"ember-cli-babel": "*",
"ember-cli-flash": "*",
"ember-auto-import": "*",
"swagger-ui-dist": "*"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { action } from '@ember/object';
import { task } from 'ember-concurrency';
import { waitFor } from '@ember/test-waiters';
import errorMessage from 'vault/utils/error-message';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import DownloadService from 'vault/services/download';
import PkiCertificateBaseModel from 'vault/models/pki/certificate/base';

Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/page/pki-configure-create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { tracked } from '@glimmer/tracking';
// TYPES
import Store from '@ember-data/store';
import Router from '@ember/routing/router';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import PkiActionModel from 'vault/models/pki/action';
import { Breadcrumb } from 'vault/vault/app-types';

Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/page/pki-issuer-edit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { task } from 'ember-concurrency';
import { waitFor } from '@ember/test-waiters';
import errorMessage from 'vault/utils/error-message';
import RouterService from '@ember/routing/router-service';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import PkiIssuerModel from 'vault/models/pki/issuer';

interface Args {
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/page/pki-key-details.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { action } from '@ember/object';
import Component from '@glimmer/component';
import RouterService from '@ember/routing/router-service';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import { inject as service } from '@ember/service';
import errorMessage from 'vault/utils/error-message';
import PkiKeyModel from 'vault/models/pki/key';
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/page/pki-role-details.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { action } from '@ember/object';
import RouterService from '@ember/routing/router-service';
import Component from '@glimmer/component';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import SecretMountPath from 'vault/services/secret-mount-path';
import { inject as service } from '@ember/service';
import errorMessage from 'vault/utils/error-message';
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/pki-generate-csr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { action } from '@ember/object';
import { task } from 'ember-concurrency';
import { waitFor } from '@ember/test-waiters';
import { expandAttributeMeta } from 'vault/utils/field-to-attrs';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import PkiActionModel from 'vault/models/pki/action';
import errorMessage from 'vault/utils/error-message';

Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/pki-generate-root.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { tracked } from '@glimmer/tracking';
import { task } from 'ember-concurrency';
import PkiActionModel from 'vault/models/pki/action';
import PkiUrlsModel from 'vault/models/pki/urls';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import errorMessage from 'vault/utils/error-message';

interface AdapterOptions {
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/pki-import-pem-bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { action } from '@ember/object';
import Component from '@glimmer/component';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import { inject as service } from '@ember/service';
import { task } from 'ember-concurrency';
import { tracked } from '@glimmer/tracking';
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/pki-role-generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Router from '@ember/routing/router';
import Store from '@ember-data/store';
import { tracked } from '@glimmer/tracking';
import errorMessage from 'vault/utils/error-message';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import DownloadService from 'vault/services/download';
import PkiCertificateGenerateModel from 'vault/models/pki/certificate/generate';
import PkiCertificateSignModel from 'vault/models/pki/certificate/sign';
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/pki/addon/components/pki-sign-intermediate-form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import { task } from 'ember-concurrency';
import PkiCertificateSignIntermediate from 'vault/models/pki/certificate/sign-intermediate';
import FlashMessageService from 'vault/services/flash-messages';
import FlashMessageService from 'ember-cli-flash/services/flash-messages';
import errorMessage from 'vault/utils/error-message';

interface Args {
Expand Down
1 change: 1 addition & 0 deletions ui/lib/pki/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dependencies": {
"ember-cli-babel": "*",
"ember-cli-htmlbars": "*",
"ember-cli-flash": "*",
"ember-cli-typescript": "*",
"@types/ember": "latest",
"@types/ember-data": "latest",
Expand Down
1 change: 1 addition & 0 deletions ui/lib/replication/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
],
"dependencies": {
"ember-cli-htmlbars": "*",
"ember-cli-flash": "*",
"ember-cli-babel": "*"
},
"ember-addon": {
Expand Down

0 comments on commit b04751d

Please sign in to comment.