Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Adding in parameters for using a proxy host connection #15

Merged
merged 8 commits into from
Jan 9, 2016

Conversation

pauldavidchristian
Copy link
Contributor

No description provided.

@vamshi-sfdc
Copy link
Contributor

  • validation logic to move to validator class
  • increment version in pom.xml

@pauldavidchristian
Copy link
Contributor Author

@vamshi-sfdc Do you recall the name of the validator class? It doesn't jump out at me?

@adarsh-ramakrishna-sfdc
Copy link
Contributor

@pauldavidchristian : Validator classes for the arguments are in the package com.sforce.cd.apexUnit.arguments. Please follow PercentageInputValidator class; you need to implement IParameterValidator for the JCommander framework to execute the validation method for a given command line argument

@adarsh-ramakrishna-sfdc
Copy link
Contributor

@pauldavidchristian : After looking at your validation code, I feel you can use PositiveIntegerValidator validator class . Please use the "validateWith" option in the parameter definition and mention the validator class

@pauldavidchristian
Copy link
Contributor Author

@adarsh-ramakrishna-sfdc Changes are in. Please let me know if you see anything else.

@@ -110,6 +110,14 @@ private PartnerConnection createConnection() {
config.setUsername(CommandLineArguments.getUsername());
config.setPassword(CommandLineArguments.getPassword());
config.setAuthEndpoint(CommandLineArguments.getOrgUrl() + "/services/Soap/u/" + SUPPORTED_VERSION);

if (CommandLineArguments.getProxyHost() != null && CommandLineArguments.getProxyPort() !=null ){
LOG.info("Setting proxy configuraiton to " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a major change.. But Can this be a debug log ?

adarsh-ramakrishna-sfdc added a commit that referenced this pull request Jan 9, 2016
Adding in parameters for using a proxy host connection
@adarsh-ramakrishna-sfdc adarsh-ramakrishna-sfdc merged commit 0fb03fd into master Jan 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants