Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Session renewer and object dump upon connection exception #38

Merged
merged 5 commits into from
Jun 29, 2016

Conversation

adarsh-ramakrishna-sfdc
Copy link
Contributor

No description provided.

@adarsh-ramakrishna-sfdc
Copy link
Contributor Author

@vamshi-sfdc @pmedapuram Please review the changes while I work on unit tests for these changes

</dependency>
<dependency>
<groupId>com.force.api</groupId>
<artifactId>force-wsc</artifactId>
<version>34.0</version>
<version>36.1.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maintain parity of version b/w partner api and wsc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are independent projects (http://mvnrepository.com/artifact/com.force.api/force-wsc , http://mvnrepository.com/artifact/com.force.api/force-partner-api) and I have used the latest versions from these (force-wsc has released 2 more versions since I developed this code; I shall change that)
Let me know if you think we need to maintain parity between these two dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes they both need to maintain parity regardless of scope of separation of those binaries

@vamshi-sfdc
Copy link
Contributor

@adarsh-ramakrishna-sfdc could you share an overview of high level summary to talk about in which all constraints connectionexception is thrown with this enhancements? May be you can pin me to all those handler call along with the insights into when this handler may be triggered

config.setProxy( CommandLineArguments.getProxyHost() , CommandLineArguments.getProxyPort());
}

config.setSessionRenewer(new SFDCSessionRenewer());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Khan was unable to look into the test scripts before he left. You may have to add those test cases up on your return. @adarsh-ramakrishna-sfdc

@adarsh-ramakrishna-sfdc
Copy link
Contributor Author

@vamshi-sfdc
Here is the Summary: This enhancement will cause session renewer to be triggered whenever connection exception or when timeout exception is thrown . We set the timeout so that the issue with connection can be caught early and session renewer is activated as quickly as possible. Apart from this, no other connection exception is thrown as part of this enhancement

@adarsh-ramakrishna-sfdc
Copy link
Contributor Author

@vamshi-sfdc @pmedapuram submitted few more file changes. Please review

@adarsh-ramakrishna-sfdc
Copy link
Contributor Author

@vamshi-sfdc @pmedapuram

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants