-
Notifications
You must be signed in to change notification settings - Fork 51
Session renewer and object dump upon connection exception #38
Conversation
@vamshi-sfdc @pmedapuram Please review the changes while I work on unit tests for these changes |
</dependency> | ||
<dependency> | ||
<groupId>com.force.api</groupId> | ||
<artifactId>force-wsc</artifactId> | ||
<version>34.0</version> | ||
<version>36.1.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain parity of version b/w partner api and wsc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two are independent projects (http://mvnrepository.com/artifact/com.force.api/force-wsc , http://mvnrepository.com/artifact/com.force.api/force-partner-api) and I have used the latest versions from these (force-wsc has released 2 more versions since I developed this code; I shall change that)
Let me know if you think we need to maintain parity between these two dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes they both need to maintain parity regardless of scope of separation of those binaries
@adarsh-ramakrishna-sfdc could you share an overview of high level summary to talk about in which all constraints connectionexception is thrown with this enhancements? May be you can pin me to all those handler call along with the insights into when this handler may be triggered |
config.setProxy( CommandLineArguments.getProxyHost() , CommandLineArguments.getProxyPort()); | ||
} | ||
|
||
config.setSessionRenewer(new SFDCSessionRenewer()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Khan was unable to look into the test scripts before he left. You may have to add those test cases up on your return. @adarsh-ramakrishna-sfdc
@vamshi-sfdc |
@vamshi-sfdc @pmedapuram submitted few more file changes. Please review |
No description provided.