-
Notifications
You must be signed in to change notification settings - Fork 51
Code cleanup. Cleaned up unnecessary null checks and unused parameters. #44
Conversation
…change in required parameters. Also added a warning comment for one line that only worls for java 1.6 and above.
@@ -359,7 +359,7 @@ public static String fetchAndAddToMapApexClassIdBasedOnName(PartnerConnection co | |||
ApexUnitUtils.shutDownWithDebugLog(e, ConnectionHandler | |||
.logConnectionException(e, connection, soql)); | |||
} | |||
if (queryResult == null || (queryResult.getRecords() != null && queryResult.getRecords().length <= 0)) { | |||
if (queryResult == null || queryResult.getRecords().length <= 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake. I will fix this tomorrow.
@glang generateHTMLReportTest failed on Travis. Did you test this locally? and on the internal jenkins instance? |
As long as you confirm that all tests pass, 👍 from me |
@adarsh-ramakrishna-sfdc the generateHTMLReportTest is a strange one. It fails and passes randomly on Travis as far as I can tell. I have tested it locally a couple of times and it always passes. I will check on jenkins on Monday, as I think my stage-jenkins job that I normally use has been renamed or removed. I'll ask @pmedapuram about that. |
Changes looks good to me 👍 |
@pmedapuram Hi, would you mind doing the second review for this pull request for me? |
👍 |
Code cleanup. Cleaned up unnecessary null checks and unused parameters.