Merge pull request #246 from forcedotcom/sm/prevent-null-undefined-in…

…-template-literal

feat: no null/undefined in template literal

.github/workflows/test.yml

@@ -8,8 +8,13 @@ jobs:
   yarn-lockfile-check:
     uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
   linux-unit-tests:
-    needs: yarn-lockfile-check
-    uses: salesforcecli/github-workflows/.github/workflows/unitTestsLinux.yml@main
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+      - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
+      - run: yarn build
+      - run: yarn test
   lint-external:
     uses: ./.github/workflows/externalLint.yml
     strategy:
@@ -39,5 +44,5 @@ jobs:
           - https://github.com/forcedotcom/source-deploy-retrieve
 
     with:
-      packageName: "eslint-config-salesforce-typescript"
+      packageName: 'eslint-config-salesforce-typescript'
       externalProjectGitUrl: ${{ matrix.externalProjectGitUrl }}

index.js

@@ -32,6 +32,7 @@ module.exports = {
     '@typescript-eslint/restrict-template-expressions': [
       'error',
       {
+        // true generally (so we get it in /test), we override it to false for src lower down
         allowNullish: true,
         allowBoolean: true,
         allowNumber: true,
@@ -94,8 +95,17 @@ module.exports = {
   ignorePatterns: ['*.js'],
   overrides: [
     {
+      // put stricter rules you only want to apply to production code here
       files: ['src/**'],
       rules: {
+        '@typescript-eslint/restrict-template-expressions': [
+          'error',
+          {
+            allowNullish: false,
+            allowBoolean: true,
+            allowNumber: true,
+          },
+        ],
         'import/no-extraneous-dependencies': [
           'error',
           {