feat: node to LTS to support github actions release (#522)

* feat: update node to LTS

BREAKING CHANGE: Major node version change requires devs to update to 16*

.github/workflows/startManualRelease.yml

@@ -8,6 +8,9 @@ jobs:
   release:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '16.0.x'
       - uses: actions/checkout@v3
         with:
           token: ${{ secrets.IDEE_GH_TOKEN }}

.nvmrc

@@ -0,0 +1 @@
+v16.0.0

README.md

@@ -46,6 +46,7 @@ npm run compile
 ```
 
 ### Open both repositories in a vscode workspace
+Note: complete the install process before this step, or you may receive errors about "Property ‘objType’ does not exist on type ‘Node’." from the Tern Server. This is due to the node_modules being improperly installed at a level above the lightning-language-server. If this does happen to you, simply remove the extra node_modules directory.
 
 ```
 cd lightning-language-server
@@ -84,8 +85,6 @@ When a commit is merged to main, we will automatically create the github release
 
 ### On-Demand publish to NPM
 Navigate to the `Actions` tab in the repository
-1. Under `Workflows` on the left side, select `Release`.
-1. Select `Run Workflow` on the top row.
-1. Enter the desired version number, following semantic versioning.
+1. Under `Workflows` on the left side, select `Manual Release`.
 1. Select `Run Workflow`, and ensure the newest version is published to npm once the workflow completes.
 1. Any failures will notify the pdt release channel internally.

package.json

@@ -6,13 +6,16 @@
     "type": "git",
     "url": "https://github.com/forcedotcom/lightning-language-server.git"
   },
+  "engines": {
+    "node": ">=16.0.0"
+  },
   "devDependencies": {
     "@commitlint/cli": "^7",
     "@commitlint/config-conventional": "^7",
     "commitizen": "^3.0.5",
     "cz-conventional-changelog": "^2.1.0",
     "@types/jest": "^27.4.0",
-    "@types/node": "^10.12.18",
+    "@types/node": "^16.0.0",
     "@typescript-eslint/eslint-plugin": "^2.22.0",
     "@typescript-eslint/parser": "^2.22.0",
     "eslint": "^6.8.0",
@@ -71,10 +74,6 @@
     "set-value": "^2.0.1",
     "js-yaml": "^3.13.1"
   },
-  "volta": {
-    "node": "12.22.12",
-    "yarn": "1.22.18"
-  },
   "config": {
     "commitizen": {
       "path": "./node_modules/cz-conventional-changelog"

packages/aura-language-server/package.json

@@ -46,7 +46,7 @@
     "@types/glob": "^7.1.3",
     "@types/jest": "^26.0.10",
     "@types/mock-fs": "^4.10.0",
-    "@types/node": "^8.10.0",
+    "@types/node": "^16.0.0",
     "@types/shelljs": "^0.8.8",
     "babel-types": "^6.26.0",
     "eslint": "^7.7.0",

packages/lwc-language-server/package.json

@@ -52,7 +52,7 @@
     "@types/fs-extra": "^5.0.4",
     "@types/glob": "^7.1.3",
     "@types/jest": "^26.0.10",
-    "@types/node": "^14.6.0",
+    "@types/node": "^16.0.0",
     "@types/normalize-path": "^3.0.0",
     "@types/xml2js": "^0.4.5",
     "babel-types": "^6.26.0",

yarn.lock

@@ -2678,26 +2678,16 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-13.7.7.tgz#1628e6461ba8cc9b53196dfeaeec7b07fa6eea99"
   integrity sha512-Uo4chgKbnPNlxQwoFmYIwctkQVkMMmsAoGGU4JKwLuvBefF0pCq4FybNSnfkfRCpC7ZW7kttcC/TrRtAJsvGtg==
 
-"@types/node@^10.12.18":
-  version "10.17.17"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.17.tgz#7a183163a9e6ff720d86502db23ba4aade5999b8"
-  integrity sha512-gpNnRnZP3VWzzj5k3qrpRC6Rk3H/uclhAVo1aIvwzK5p5cOrs9yEyQ8H/HBsBY0u5rrWxXEiVPQ0dEB6pkjE8Q==
-
-"@types/node@^14.6.0":
-  version "14.6.4"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.6.4.tgz#a145cc0bb14ef9c4777361b7bbafa5cf8e3acb5a"
-  integrity sha512-Wk7nG1JSaMfMpoMJDKUsWYugliB2Vy55pdjLpmLixeyMi7HizW2I/9QoxsPCkXl3dO+ZOVqPumKaDUv5zJu2uQ==
+"@types/node@^16.0.0":
+  version "16.18.3"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.3.tgz#d7f7ba828ad9e540270f01ce00d391c54e6e0abc"
+  integrity sha512-jh6m0QUhIRcZpNv7Z/rpN+ZWXOicUUQbSoWks7Htkbb9IjFQj4kzcX/xFCkjstCj5flMsN8FiSvt+q+Tcs4Llg==
 
 "@types/node@^6.0.46":
   version "6.14.9"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-6.14.9.tgz#733583e21ef0eab85a9737dfafbaa66345a92ef0"
   integrity sha512-leP/gxHunuazPdZaCvsCefPQxinqUDsCxCR5xaDUrY2MkYxQRFZZwU5e7GojyYsGB7QVtCi7iVEl/hoFXQYc+w==
 
-"@types/node@^8.10.0":
-  version "8.10.59"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-8.10.59.tgz#9e34261f30183f9777017a13d185dfac6b899e04"
-  integrity sha512-8RkBivJrDCyPpBXhVZcjh7cQxVBSmRk9QM7hOketZzp6Tg79c0N8kkpAIito9bnJ3HCVCHVYz+KHTEbfQNfeVQ==
-
 "@types/normalize-package-data@^2.4.0":
   version "2.4.0"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"