feat: node to LTS to support github actions release #522
Conversation
BREAKING CHANGE: Major node version change requires devs to update to 18.11.*
| skip-version-file: true | ||
| skip-on-empty: false | ||
| output-file: false | ||
| pre-commit: ./scripts/bump-lerna-version.js |
There was a problem hiding this comment.
hummmmm insteresting. So the conventional-changelog is also going to try and bump the version in package.json. Does skip-version-file take care of that for us I guess? Does bump-lerna-version also do a commit to commit all the packge.*json updates?
I'm wondering if we just need to do the version bump in learn as a separate step that happens before (or maybe even instead of) the change log thing.
There was a problem hiding this comment.
So the reason I like to have it here is so the math is the same for the version + the git tag. Conventional changelog decides what the version should be and passes it to the bump-lerna-version script for us to read and just set, rather than having to decide that separately. We don't seem to have any option to set the version into conventional changelog... so this is the way.
There was a problem hiding this comment.
gotcha, makes sense. I was just looking at the error and can't understand why it's beefing about the export in that preCommit script.
randi274
changed the title
What does this PR do?
Bumps node to LTS-1 (v16.0.0) as we were having issues publishing with a greatly outdated node version.
What issues does this PR fix or reference?
Continuing improvements to #521.
BREAKING CHANGE: Major node version change requires devs to update to 16.0.*