feat: add new lwc directives as autocomplete options in 242/258 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
reviewed
Apr 18, 2023
| @@ -49,7 +49,7 @@ npm run compile | |||
| Note: complete the install process before this step, or you may receive errors about "Property ‘objType’ does not exist on type ‘Node’." from the Tern Server. This is due to the node_modules being improperly installed at a level above the lightning-language-server. If this does happen to you, simply remove the extra node_modules directory. | |||
|
|
|||
| ``` | |||
| cd lightning-language-server | |||
| cd ../lightning-language-server | |||
There was a problem hiding this comment.
Does your local setup require moving up a directory? For me this is correct, as my setup looks like:
- Repos/lightning-language-server
- Repos/salesforcedx-vscode
There was a problem hiding this comment.
Yes! I have that same structure, but as in the previous set of steps we're standing in salesforcedx-vscode, we need the ../ to go back and then enter lls
randi274
reviewed
Apr 18, 2023
randi274
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Looking great! I especially appreciated the extra notes recommending the usage of the newer directives. Since we are making some doc-style changes, let's get @sbudhirajadoc to take a look before merging in.
sbudhirajadoc
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support (for autocomplete as well) to the following new LWC directives that were released with 242:
What issues does this PR fix or reference?
@W-12051474@
Functionality after
Autocomplete
On hover info
