Lf/message server graceful error #267
Conversation
|
The author of this PR, LisandroFernandezSF, is not an activated member of this organization on Codecov. |
| @@ -21,7 +21,7 @@ export function getMacAddress() { | |||
| const macAddresses = Object.keys(networkInterfaces) | |||
| .reduce((macAddresses: string[], networkInterfaceName) => { | |||
| const networkInterfaceInfo = | |||
| networkInterfaces[networkInterfaceName]; | |||
| networkInterfaces[networkInterfaceName] || []; | |||
There was a problem hiding this comment.
Wasn't the issue with network interfaces happening in this PR? I wasn't under the impression this current PR was experiencing issues with the tests. I'd be more curious to see if these changes have an effect on the other PR.
As a note, if we move forward with this change then tests will need to be added to machineId.test.ts. I'm hesitant to move forward with this change until we understand why your test scenario was failing though. There could be a different underlying issue that we need to address.
There was a problem hiding this comment.
Indeed the issue with network interfaces is happening in both PRs.
Ok, I can dedicate more time to understand why the test scenario is failing.
There was a problem hiding this comment.
Can you show me the test failure where this was happening on this PR too? Also, is it reproducible locally for you?
There was a problem hiding this comment.
The test is not failing, the yarn build process is failing. It shows Object is possibly 'undefined' for this line.
There was a problem hiding this comment.
It might be related to this issue nodejs/node#30504
There was a problem hiding this comment.
If the issue is at build time I think the current change might be enough. If it is happening at runtime then we'll just return undefined when running getMacAddress(). Is there anything else I might be missing @sfsholden @LisandroFernandezSF ?
There was a problem hiding this comment.
Ah okay, if this is happening at build time then I'm less concerned about adding in this change.
| @@ -0,0 +1,3 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`LWCMessageService rollup plugin load should throw error for @salesforce/messageChannel imports 1`] = `"You can't preview a component using Lightning Message Service. Test the component directly in the org"`; | |||
There was a problem hiding this comment.
@LisandroFernandezSF - the message looks good. Do you need me to look at anything else?
There was a problem hiding this comment.
No Emily, I think that was everything
|
|
||
| const service = new LWCMessageService(); | ||
| const plugin = service.getPlugin(); | ||
| function loadApexContinuation() { |
There was a problem hiding this comment.
nit: this has nothing to do with apex continuations so let's change the name of this function
* fix: lms new message * fix: using a real regexp * fix: adding test file * fix: tsc and lint errors
* fix: lms new message * fix: using a real regexp * fix: adding test file * fix: tsc and lint errors
What does this PR do?
It shows a new error message for LMS
What issues does this PR fix or reference?
@W-7586088@