Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement progress api #159

Merged
merged 4 commits into from
Mar 15, 2021
Merged

feat: implement progress api #159

merged 4 commits into from
Mar 15, 2021

Conversation

xyc
Copy link
Contributor

@xyc xyc commented Mar 11, 2021

What does this PR do?

progress api implementation

What issues does this PR fix or reference?

@W-8911022@

@xyc xyc requested a review from a team as a code owner March 11, 2021 01:14
@xyc xyc requested a review from AnanyaJha March 11, 2021 01:45
@AnanyaJha
Copy link
Contributor

do we want to emit any other progress events as we're collecting the results from the asynchronous test run? ie. 'Retrieving Test Run Summary record' or 'Query for aggregate code coverage results' etc.

@xyc
Copy link
Contributor Author

xyc commented Mar 12, 2021

@AnanyaJha Do you mean to add progress in formatAsyncResults? We could add that. Currently we don't have it reported in CLI either, but we could add them if needed.

@@ -36,6 +36,9 @@ export const messages = {
streamingTransportUp: 'Listening for streaming state changes...',
streamingTransportDown: 'Faye client generated a transport:down event.',
streamingProcessingTestRun: 'Processing test run %s',
retrievingTestRunSummary: 'Retrieving test run summary record',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekapner @AnanyaJha new messages for progress in retrieving test run summary and querying for aggregate code coverage results, during async test runs. Currently this is reported in library API, but not exposed to the users yet.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faye client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faye is the lib used here, we might want to rephrase it as "Streaming client is down" etc. @AnanyaJha

@xyc xyc merged commit 82c86a8 into develop Mar 15, 2021
@xyc xyc deleted the xyc/progress-api branch March 15, 2021 18:54
rcoringrato-sfdc pushed a commit that referenced this pull request Mar 18, 2021
* feat: implement progress api

* feat: localized progress message

* feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
rcoringrato-sfdc pushed a commit that referenced this pull request Mar 18, 2021
* feat: implement progress api

* feat: localized progress message

* feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
klewis-sfdc pushed a commit that referenced this pull request Oct 24, 2022
* feat: implement progress api

* feat: localized progress message

* feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants