-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement progress api #159
Conversation
do we want to emit any other progress events as we're collecting the results from the asynchronous test run? ie. 'Retrieving Test Run Summary record' or 'Query for aggregate code coverage results' etc. |
@AnanyaJha Do you mean to add progress in |
@@ -36,6 +36,9 @@ export const messages = { | |||
streamingTransportUp: 'Listening for streaming state changes...', | |||
streamingTransportDown: 'Faye client generated a transport:down event.', | |||
streamingProcessingTestRun: 'Processing test run %s', | |||
retrievingTestRunSummary: 'Retrieving test run summary record', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekapner @AnanyaJha new messages for progress in retrieving test run summary and querying for aggregate code coverage results, during async test runs. Currently this is reported in library API, but not exposed to the users yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faye client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faye
is the lib used here, we might want to rephrase it as "Streaming client is down" etc. @AnanyaJha
* feat: implement progress api * feat: localized progress message * feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
* feat: implement progress api * feat: localized progress message * feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
* feat: implement progress api * feat: localized progress message * feat: retrievingTestRunSummary,queryingForAggregateCodeCoverage progress
What does this PR do?
progress api implementation
What issues does this PR fix or reference?
@W-8911022@