Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(namespace): incorrect namespacing of test classes #325

Closed
wants to merge 2 commits into from

Conversation

JonnyPower
Copy link
Contributor

closes #296

What does this PR do?

Correctly applies namespace to namespaced test classes

What issues does this PR fix or reference?

#296

Functionality Before

Classes were reporting with namespace and __ - this is not correct, and resubmitting a test run with that full name fails. Correct namespacing of apex classes is NS.<class>

Functionality After

Correctly return class full names

@JonnyPower
Copy link
Contributor Author

@mshanemc / @jeffb-sfdc is there a process I need to follow to have PRs queued up for review? I notice on other PRs there's a requirement for a GUS number internally, is that something you can help with?

@JonnyPower
Copy link
Contributor Author

Hi @AnanyaJha - what's the process for getting reviewed / kicking off CI builds?

@AnanyaJha
Copy link
Contributor

Hi @AnanyaJha - what's the process for getting reviewed / kicking off CI builds?

Hi @JonnyPower ! Apologies the team hasn't been able to take a look at your PR yet - I'll ask a member of our engineering team to review and they should be able to kick off the appropriate builds.

@JonnyPower
Copy link
Contributor Author

Hi @AnanyaJha, any update? these are getting quite stale and the more stale they become the higher risk of integration issues that will need remediated.

I have another PR also in the same state; #324

@JonnyPower
Copy link
Contributor Author

@AnanyaJha bumping thread 📭

@JonnyPower
Copy link
Contributor Author

@AnanyaJha :tumbleweed:

@JonnyPower
Copy link
Contributor Author

@shetzel could you have a look at this one too?

@shetzel
Copy link
Collaborator

shetzel commented Dec 1, 2023

@JonnyPower - I added it to my list. Thanks for the contribution!

@shetzel
Copy link
Collaborator

shetzel commented Dec 4, 2023

@JonnyPower - this looks good to me. I have an equivalent PR that is up to date with main and passed all tests. (#339)
I'd like for you to get the credit as author though so can you please update your fork with the latest from main so we can merge your PR rather than mine? If you don't care, I'll just merge 339 since it's the same.

@shetzel
Copy link
Collaborator

shetzel commented Dec 5, 2023

fixed with equivalent PR: #339

@shetzel shetzel closed this Dec 5, 2023
@JonnyPower
Copy link
Contributor Author

thanks @shetzel - appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants