-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(namespace): incorrect namespacing of test classes #325
Conversation
@mshanemc / @jeffb-sfdc is there a process I need to follow to have PRs queued up for review? I notice on other PRs there's a requirement for a GUS number internally, is that something you can help with? |
Hi @AnanyaJha - what's the process for getting reviewed / kicking off CI builds? |
Hi @JonnyPower ! Apologies the team hasn't been able to take a look at your PR yet - I'll ask a member of our engineering team to review and they should be able to kick off the appropriate builds. |
Hi @AnanyaJha, any update? these are getting quite stale and the more stale they become the higher risk of integration issues that will need remediated. I have another PR also in the same state; #324 |
@AnanyaJha bumping thread 📭 |
@AnanyaJha :tumbleweed: |
@shetzel could you have a look at this one too? |
@JonnyPower - I added it to my list. Thanks for the contribution! |
@JonnyPower - this looks good to me. I have an equivalent PR that is up to date with |
fixed with equivalent PR: #339 |
thanks @shetzel - appreciate it! |
closes #296
What does this PR do?
Correctly applies namespace to namespaced test classes
What issues does this PR fix or reference?
#296
Functionality Before
Classes were reporting with namespace and
__
- this is not correct, and resubmitting a test run with that full name fails. Correct namespacing of apex classes isNS.<class>
Functionality After
Correctly return class full names