feat: Check for query limits before getting apex test results @W-8379096@ #92
Conversation
AnanyaJha
force-pushed
the
aj/queryLim
branch
from
078d9eb to
42066cd
Compare
| @@ -27,6 +27,9 @@ import * as util from 'util'; | |||
| import { nls } from '../i18n'; | |||
| import { StreamingClient } from '../streaming'; | |||
|
|
|||
| // query char limit *should be* 100,000, but is closer to 12,000 | |||
There was a problem hiding this comment.
Is this based on testing we did or how did we come up with the 12,000 number ? Is it a know bug in the api that the 100,000 limit does not work ?
There was a problem hiding this comment.
It's based on testing so far, but I've also reached out to the tooling api team to see if this is expected behavior
There was a problem hiding this comment.
Since v48 it's 100,000, before it was 20,000.
There was a problem hiding this comment.
The doc says "by default", not sure if that means it could be set lower for a particular org for whatever reason
There was a problem hiding this comment.
Yeah I originally had a check for the api version and used that to determine the query limit (100k vs 20k), but changed it to just 12,000 when the queries kept failing for me 😢 I'll update this based on what the tooling team says about the expected behavior
There was a problem hiding this comment.
The two limits we've been running into are REST API limits - the URI can't exceed 16,348 bytes & the URI + headers can't exceed 16,348 bytes from here. I've been able to consistently reproduce hitting the URI+headers limit with any query greater than 12,400 characters, so to be on the safe side I'd feel comfortable with keeping the limit at 12,400
A workaround for the limits is to use the soap api instead, so I looked into the equivalent of the metadata api invoke method you mentioned Bryan, but it doesn't look like anything like that exists for tooling api yet
AnanyaJha
force-pushed
the
aj/queryLim
branch
2 times, most recently
from
1d4be2b to
3f28eb6
Compare
| const record = { | ||
| Id: '7092M000000Vt94QAC', | ||
| Status: ApexTestQueueItemStatus.Completed, | ||
| ApexClassId: '01p2M00000O6tXZQAZ', | ||
| TestRunResultId: '05m2M000000TgYuQAK' | ||
| }; | ||
|
|
||
| const records = []; | ||
| const queryIds = []; | ||
| let count = 700; | ||
| while (count > 0) { | ||
| records.push(record); | ||
| queryIds.push(record.Id); | ||
| count--; | ||
| } |
AnanyaJha
force-pushed
the
aj/queryLim
branch
from
dcc4495 to
96eaf50
Compare
What does this PR do?
This PR adds in a check to ensure that we don't surpass the query limits and return a
<h1>Bad Message 431</h1><pre>reason: Request Header Fields Too Largeerror. The query character limit should be 100,000 according to documentation, but from testing it appears to be closer to 12,000.What issues does this PR fix or reference?
@W-8379096@