Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Update lightning LSPs to 2.0.9 (#1197) #1198

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Mar 27, 2019

What does this PR do?

Ports PR #1197 to develop branch

What issues does this PR fix or reference?

* add preview preference for lightning-explorer / fix build issue with opn

* update language servers to 2.0.9

* add dependency back for i18n
@lcampos lcampos requested review from nrkruk and brpowell March 27, 2019 21:31
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #1198 into develop will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1198      +/-   ##
==========================================
- Coverage    71.02%   70.9%   -0.13%     
==========================================
  Files          196     196              
  Lines         7379    7379              
  Branches       780     780              
==========================================
- Hits          5241    5232       -9     
- Misses        1983    1991       +8     
- Partials       155     156       +1
Impacted Files Coverage Δ
...code-lightning/src/commands/quickpick/quickpick.ts 0% <0%> (ø) ⬆️
...cts-faux-generator/src/describe/sObjectDescribe.ts 77.61% <0%> (-10.45%) ⬇️
...edx-vscode-core/src/telemetry/telemetryReporter.ts 50.7% <0%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c559f3d...32769c3. Read the comment docs.

@lcampos lcampos merged commit fb1ed41 into develop Mar 27, 2019
@lcampos lcampos deleted the lcampos/port-aura-ls-209 branch March 27, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants