Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc aura/lwc lsp bug fixes, support lwc component methods in tree, unknown project types #1232

Closed
wants to merge 6 commits into from

Conversation

midzelis
Copy link

@midzelis midzelis commented Apr 4, 2019

What does this PR do?

Bug fixes, and support for unknown project types

What issues does this PR fix or reference?

fix: build: Remove hard dependency on vscode-core
fix: component-tree: show method icon for lwc component methods
fix: component-tree: display no components message when no components found
fix: component-tree: filter aura/lwc system namespaces for unknown workspaces, when no custom components detected
fix: telemetry: be sure to always activate vscode-core if installed
fix: lsp: launch lsp client with system version of node instead of built-in
fix: plugin: activate plugin on explorer view

Min Idzelis added 2 commits April 3, 2019 13:17
@midzelis midzelis requested a review from nrkruk April 4, 2019 22:02
@midzelis midzelis changed the title Aura/LWC LSP bug fixes fix: misc aura/lwc lsp bug fixes, support lwc component methods in tree, unknown project types Apr 8, 2019
@nrkruk nrkruk closed this May 2, 2019
@randi274 randi274 deleted the midzelis/BUG_FIXES branch July 22, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants