Expose create commands only on default folders #1235
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1235 +/- ##
===========================================
+ Coverage 70.98% 71.01% +0.02%
===========================================
Files 196 196
Lines 7397 7397
Branches 781 781
===========================================
+ Hits 5251 5253 +2
+ Misses 1990 1989 -1
+ Partials 156 155 -1
Continue to review full report at Codecov.
|
| @@ -116,15 +116,15 @@ | |||
| "explorer/context": [ | |||
| { | |||
| "command": "sfdx.force.apex.class.create", | |||
| "when": "explorerResourceIsFolder && resourceFilename != aura && resourceFilename != lwc && sfdx:project_opened" | |||
| "when": "explorerResourceIsFolder && resourceFilename == classes && sfdx:project_opened" | |||
There was a problem hiding this comment.
This is good but looks like it breaks a test so need to get that updated as well.
There was a problem hiding this comment.
Looks good to me too. The test failure doesn't look related to these changes, I was seeing that fail locally for me on another branch as well...
There was a problem hiding this comment.
@brpowell Ah thanks, I was stumped on that one. I couldn't figure out why this change broke some random localization test.
| }, | ||
| { | ||
| "command": "sfdx.force.visualforce.component.create", | ||
| "when": "explorerResourceIsFolder && resourceFilename != aura && resourceFilename != lwc && sfdx:project_opened" | ||
| "when": "explorerResourceIsFolder && resourceFilename != components && sfdx:project_opened" |
There was a problem hiding this comment.
shouldn't this be resourceFilename == components
| }, | ||
| { | ||
| "command": "sfdx.force.visualforce.page.create", | ||
| "when": "explorerResourceIsFolder && resourceFilename != aura && resourceFilename != lwc && sfdx:project_opened" | ||
| "when": "explorerResourceIsFolder && resourceFilename != pages && sfdx:project_opened" |
| @@ -144,7 +144,7 @@ | |||
| }, | |||
| { | |||
| "command": "sfdx.force.apex.trigger.create", | |||
| "when": "explorerResourceIsFolder && resourceFilename != aura && resourceFilename != lwc && sfdx:project_opened" | |||
| "when": "explorerResourceIsFolder && resourceFilename != triggers && sfdx:project_opened" | |||
There was a problem hiding this comment.
resourceFilename == triggers
ntotten
force-pushed
the
default_folders_create
branch
from
4f91a70 to
46c5f2e
Compare
What does this PR do?
Limits create commands to only be exposed on default folders
What issues does this PR fix or reference?
Closes #852, @W-5746531@