Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent lwc and lightning extensions activating in non-Salesforce projects #2070

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Mar 12, 2020

What does this PR do?

These changes will prevent LWC & Lightning extensions activating in non-Salesforce projects which cause the salesforce-core extension to activate and throw errors.

This addresses issues #1988 and #2065

What issues does this PR fix or reference?

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2070 into release/v48.6.0 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v48.6.0    #2070      +/-   ##
===================================================
+ Coverage            73.08%   73.10%   +0.02%     
===================================================
  Files                  236      236              
  Lines                 8804     8804              
  Branches              1003     1003              
===================================================
+ Hits                  6434     6436       +2     
+ Misses                2128     2126       -2     
  Partials               242      242              
Impacted Files Coverage Δ
...forcedx-vscode-core/src/channels/channelService.ts 85.71% <0.00%> (+2.38%) ⬆️
...code-lwc/src/testSupport/testRunner/testWatcher.ts 82.85% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8ac71...b0c2968. Read the comment docs.

@lcampos lcampos changed the title Remove lwc and lightning extensions activating in non-Salesforce projects Prevent lwc and lightning extensions activating in non-Salesforce projects Mar 12, 2020
@lcampos lcampos merged commit 9dd7391 into release/v48.6.0 Mar 12, 2020
@lcampos lcampos deleted the lcampos/fix-issue-2065 branch March 12, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants