Testing Support for LWC: Support internal workspace #2094
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2094 +/- ##
===========================================
+ Coverage 74.21% 74.30% +0.08%
===========================================
Files 239 244 +5
Lines 8999 9046 +47
Branches 1028 1033 +5
===========================================
+ Hits 6679 6722 +43
- Misses 2057 2061 +4
Partials 263 263
Continue to review full report at Codecov.
|
xyc
changed the title
…tion; remove onDidChangeWorkspaceFolders since we do not support multiroot
| @@ -81,6 +81,7 @@ | |||
| }, | |||
| "activationEvents": [ | |||
| "workspaceContains:sfdx-project.json", | |||
| "workspaceContains:../workspace-user.xml", | |||
There was a problem hiding this comment.
This ensures proper activation in partial workspace.
packages/salesforcedx-vscode-lwc/src/testSupport/workspace/getCliArgsFromJestArgs.ts
Outdated
Show resolved
Hide resolved
| @@ -51,6 +51,8 @@ export const messages = { | |||
| 'SFDX: Navigate to Lightning Web Component Test', | |||
| no_lwc_jest_found_text: | |||
| 'sfdx-lwc-jest is not installed. Install it from https://developer.salesforce.com/docs/component-library/documentation/lwc/lwc.unit_testing_using_jest_installation', | |||
| no_lwc_testrunner_found_text: | |||
There was a problem hiding this comment.
This exposes a url to an internal repo, not sure if that's common practice. @hbc-bindu @ekapner do you have any suggestions here ?
There was a problem hiding this comment.
I would say we don't want to expose an internal repo. @lcampos -- Want to make sure I understand your question. And then we can decide next steps. Can they follow the instrux and be successful? If so, we can update the topic to remove the reference to the internal repo. If they must have access to the repo to be successful, that's a problem. And I would need to discuss with Stephanie and @hbc-bindu what the alternatives are.
There was a problem hiding this comment.
I've removed the url for now (It's gated anyway). @ekapner @hbc-bindu Let me know what you think with the current text. We will provide them with documentation in internal channels.
packages/salesforcedx-vscode-lwc/src/testSupport/workspace/getCliArgsFromJestArgs.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-vscode-lwc/src/testSupport/testRunner/testRunner.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: lcampos <lcamposguajardo@gmail.com>
lwc test: support for internal dev workspace
lwc test: support for internal dev workspace
What does this PR do?
Support internal workspace
What issues does this PR fix or reference?
Parent issue #1703, @W-6975995@
Functionality Before
For LWC testing, SFDX workspace is supported
Functionality After
For LWC testing, SFDX and internal workspaces are supported