fix(apex and core package.json): update SDR to v5.12.3 to pick up fix for child reads #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for child reads n
jag-j
approved these changes
Mar 3, 2022
floralan
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update SDR dependency to v15.12.3 which include readFileSync fix for ZipTree. This fixes the issue where we can diff objects against the org.
What issues does this PR fix or reference?
@W-10159064@ @W-10120433@
Functionality Before
Failed to retrieve diff for objects.
Deploy source to org fails for custom objects.
Functionality After
Successfully diffs objects against org.
SFDX: Diff Folder Against OrgDeploy source to org works as expected.
01:50:45.605 Starting SFDX: Deploy Source to Org
=== Deployed Source
STATE FULL NAME TYPE PROJECT PATH
───────── ─────────────────── ──────────── ────────────────────────────────────────────────────────────────────────
Unchanged Order__c.Account__c CustomField force-app/main/default/objects/Order__c/fields/Account__c.field-meta.xml
Changed Order__c CustomObject force-app/main/default/objects/Order__c/Order__c.object-meta.xml
01:50:49.316 ended SFDX: Deploy Source to Org