feat: add flow for creating LWC jest debug config #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Mar 15, 2022
| "force_lightning_lwc_mobile_log_level": "Log level used when calling SFDX Preview on Mobile command." | ||
| "force_lightning_lwc_mobile_log_level": "Log level used when calling SFDX Preview on Mobile command.", | ||
| "force_lightning_lwc_debugger": "Debug: LWC Jest Tests", | ||
| "force_lightning_lwc_debugger_desc": "Debug configuretion for running LWC jest tests in vscode." |
randi274
reviewed
Mar 16, 2022
jeffb-sfdc
reviewed
Mar 18, 2022
jag-j
reviewed
Mar 18, 2022
| "name": "%force_lightning_lwc_debugger%", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "program": "^\"\\${workspaceFolder}/node_modules/.bin/sfdx-lwc-jest\"", |
There was a problem hiding this comment.
Will forward slashes for windows as well?
There was a problem hiding this comment.
I believe so but intend to verify. I did some splunking at https://github.com/jest-community/vscode-jest/blob/e3dbd7299a13730b34697601a10e323ba6286649/package.json#L337 and followed their existing pattern.
There was a problem hiding this comment.
@gbockus-sf - I'm the QA for this story as well. I will run a sanity check on windows today.
There was a problem hiding this comment.
I've been fighting it this AM. I think there will be an update required for windows. Will keep you posted
There was a problem hiding this comment.
@jag-sfdc verified with circle build 31400 we are good on windows 👍
jag-j
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new debugger configuration for LWC jest tests.
A few items to note that were different from how the tickets was written.
What issues does this PR fix or reference?
@W-10536658@
Functionality Before
No debug configuration available for LWC jest tests
Functionality After