fix: hover error fixed in LSP #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumes the latest lightning-language-server packages, which fixes the textDocument/hover error in the event that the lsp is incorrectly parsing the content of .js files. #3929
floralan
approved these changes
Apr 5, 2022
gbockus-sf
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Using the ebike project I just edited some existing html to QE this issue. Used the currently released version (v54.6.1) to verify the error condition. Used the vsixes from the last build to verify this fixed.
✅ Verified that I got the error when editing HTML in LWC prior to the update
✅ Verified that the error no longer occurred after update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consumes the latest lightning-language-server packages, which fixes the textDocument/hover error in
the event that the lsp is incorrectly parsing the content of .js files.
What issues does this PR fix or reference?
#3929, @W-10857157@
Functionality Before
Users were often experiencing the textDocument/hover error, which drew focus to the output panel and caused excessive noise.
Functionality After
This error is now suppressed, and users can continue developing without being constantly pestered with unhelpful errors 😌