fix: allow for escaping lwc test create command #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed an issue where escaping from the lwc test create command was generating an exception. code now exits gracefully and allows for a quiet escape. #3983
klewis-sfdc
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
✅ Escape closes the dialog without the error dialog 👍🏽
✅ Existing behavior works - creates new test file if one didn't exist - "Test file already exists" message in the Output if one does already exist 👍🏽
✅ Tests pass and the new test looks great. 👍🏽
Thanks, @randi274 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed an issue where escaping from the 'Create Lightning Web Component Test' could generate an error.
What issues does this PR fix or reference?
#3983 , @W-10915684@
Functionality Before
When you run the command 'Create Lightning Web Component Test', select a directory, then exit out of selecting a component, you get a nasty error, shown in #3983.
Functionality After
Escaping that command is quiet and error-message free, as it should be.