Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in null for TraceFlag StartDate #743

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Conversation

JimSuplizio
Copy link
Contributor

What does this PR do?

When creating/updating the TraceFlag's StartTime use null instead of the local system time on whatever machine happens to be running VS Code. The problem here is that that local machine and appserver are more than likely not going to be in sync. This means that creating TraceFlag StartTime from the local system time, especially one whose time is ahead of the appserver, would end up causing a delay for when logging started. Instead, passing null for the start time which will tell logging to use the now time on the server side which means the very next command will log appropriately.

What issues does this PR fix or reference?

@W-5540032@

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #743 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #743   +/-   ##
========================================
  Coverage    74.23%   74.23%           
========================================
  Files          163      163           
  Lines         6609     6609           
  Branches      1039     1039           
========================================
  Hits          4906     4906           
  Misses        1433     1433           
  Partials       270      270
Impacted Files Coverage Δ
...de-core/src/commands/forceStartApexDebugLogging.ts 46.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2705003...5f781d5. Read the comment docs.

@lcampos lcampos merged commit 3cb73a7 into develop Nov 13, 2018
@lcampos lcampos deleted the jsuplizio/TraceFlagStartFix branch November 13, 2018 17:41
@lcampos
Copy link
Contributor

lcampos commented Nov 15, 2018

Fix for #710

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): James Suplizio <j***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants