Pass in null for TraceFlag StartDate #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When creating/updating the TraceFlag's StartTime use null instead of the local system time on whatever machine happens to be running VS Code. The problem here is that that local machine and appserver are more than likely not going to be in sync. This means that creating TraceFlag StartTime from the local system time, especially one whose time is ahead of the appserver, would end up causing a delay for when logging started. Instead, passing null for the start time which will tell logging to use the now time on the server side which means the very next command will log appropriately.
What issues does this PR fix or reference?
@W-5540032@