Skip to content

Commit

Permalink
chore: pin ts for ts-patch vs ts 5.5 bug
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Jun 21, 2024
1 parent 5b112f8 commit 6ee3c61
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"benchmark": "^2.1.4",
"ts-node": "^10.9.2",
"ts-patch": "^3.2.0",
"typescript": "^5.4.5"
"typescript": "5.4.5"
},
"repository": {
"type": "git",
Expand Down
7 changes: 6 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5037,7 +5037,12 @@ typedoc@^0.25.13:
minimatch "^9.0.3"
shiki "^0.14.7"

"typescript@^4.6.4 || ^5.2.2", typescript@^5.4.3, typescript@^5.4.5:
typescript@5.4.5:
version "5.4.5"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.5.tgz#42ccef2c571fdbd0f6718b1d1f5e6e5ef006f611"
integrity sha512-vcI4UpRgg81oIRUFwR0WSIHKt11nJ7SAVlYNIu+QpqeyXP+gpQJy/Z4+F0aGxSE4MqwjyXvW/TzgkLAx2AGHwQ==

"typescript@^4.6.4 || ^5.2.2", typescript@^5.4.3:
version "5.5.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.2.tgz#c26f023cb0054e657ce04f72583ea2d85f8d0507"
integrity sha512-NcRtPEOsPFFWjobJEtfihkLCZCXZt/os3zf8nTxjVH3RvTSxjrCamJpbExGvYOF+tFHc3pA65qpdwPbzjohhew==
Expand Down

3 comments on commit 6ee3c61

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 6ee3c61 Previous: 42d7a2b Ratio
Child logger creation 471782 ops/sec (±1.32%) 481565 ops/sec (±1.43%) 1.02
Logging a string on root logger 784242 ops/sec (±8.55%) 869848 ops/sec (±9.52%) 1.11
Logging an object on root logger 619397 ops/sec (±8.68%) 592584 ops/sec (±7.69%) 0.96
Logging an object with a message on root logger 5988 ops/sec (±211.84%) 24150 ops/sec (±183.81%) 4.03
Logging an object with a redacted prop on root logger 449800 ops/sec (±7.35%) 470254 ops/sec (±11.44%) 1.05
Logging a nested 3-level object on root logger 344327 ops/sec (±8.73%) 23631 ops/sec (±183.45%) 0.06862952948795767

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 6ee3c61 Previous: 42d7a2b Ratio
Logging an object with a message on root logger 5988 ops/sec (±211.84%) 24150 ops/sec (±183.81%) 4.03

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 6ee3c61 Previous: 42d7a2b Ratio
Child logger creation 324718 ops/sec (±0.80%) 325931 ops/sec (±1.17%) 1.00
Logging a string on root logger 747402 ops/sec (±4.67%) 742782 ops/sec (±4.96%) 0.99
Logging an object on root logger 584520 ops/sec (±13.52%) 593401 ops/sec (±7.82%) 1.02
Logging an object with a message on root logger 7529 ops/sec (±201.11%) 7317 ops/sec (±201.08%) 0.97
Logging an object with a redacted prop on root logger 444036 ops/sec (±5.62%) 440422 ops/sec (±17.11%) 0.99
Logging a nested 3-level object on root logger 316245 ops/sec (±5.09%) 324988 ops/sec (±6.73%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.