chore: updates from devScripts (#1255)

forcedotcom · Mar 10, 2024 · 2a18348 · 2a18348
1 parent db5fdfd
commit 2a18348
Show file tree

Hide file tree

Showing 4 changed files with 202 additions and 260 deletions.
diff --git a/package.json b/package.json
@@ -41,7 +41,7 @@
   },
   "devDependencies": {
     "@salesforce/cli-plugins-testkit": "^5.1.10",
-    "@salesforce/dev-scripts": "^8.4.1",
+    "@salesforce/dev-scripts": "^8.4.2",
     "@types/deep-equal-in-any-order": "^1.0.1",
     "@types/fast-levenshtein": "^0.0.4",
     "@types/graceful-fs": "^4.1.9",

diff --git a/src/registry/coverage.ts b/src/registry/coverage.ts
@@ -15,7 +15,7 @@ import { CoverageObject } from '../../src/registry/types';
 
 const getProxiedOptions = (url: string): OptionsOfTextResponseBody => ({
   timeout: {
-    request: 10000,
+    request: 10_000,
   },
   agent: {
     https: new ProxyAgent(),

diff --git a/test/convert/metadataConverter.test.ts b/test/convert/metadataConverter.test.ts
@@ -55,7 +55,7 @@ describe('MetadataConverter', () => {
   });
 
   it('should generate package name using timestamp when option omitted', async () => {
-    const timestamp = 123456;
+    const timestamp = 123_456;
     const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
     $$.SANDBOX.stub(Date, 'now').returns(timestamp);
 
@@ -149,7 +149,7 @@ describe('MetadataConverter', () => {
     });
 
     it('should write manifest for metadata format conversion', async () => {
-      const timestamp = 123456;
+      const timestamp = 123_456;
       const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
       $$.SANDBOX.stub(Date, 'now').returns(timestamp);
       const expectedContents = await new ComponentSet(components).getPackageXml();
@@ -164,7 +164,7 @@ describe('MetadataConverter', () => {
     });
 
     it('should write destructive changes post manifest when ComponentSet has deletes marked for post', async () => {
-      const timestamp = 123456;
+      const timestamp = 123_456;
       const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
       $$.SANDBOX.stub(Date, 'now').returns(timestamp);
       const component1 = new SourceComponent({
@@ -196,7 +196,7 @@ describe('MetadataConverter', () => {
     });
 
     it('should write destructive changes pre manifest when ComponentSet has deletes', async () => {
-      const timestamp = 123456;
+      const timestamp = 123_456;
       const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
       $$.SANDBOX.stub(Date, 'now').returns(timestamp);
       const component1 = new SourceComponent({
@@ -229,7 +229,7 @@ describe('MetadataConverter', () => {
     });
 
     it('should write manifest for metadata format conversion with sourceApiVersion', async () => {
-      const timestamp = 123456;
+      const timestamp = 123_456;
       const packagePath = join(outputDirectory, `${MetadataConverter.DEFAULT_PACKAGE_PREFIX}_${timestamp}`);
       $$.SANDBOX.stub(Date, 'now').returns(timestamp);
       const compSet = new ComponentSet(components);
@@ -247,7 +247,7 @@ describe('MetadataConverter', () => {
     });
 
     it('should write the fullName entry when packageName is provided', async () => {
-      const timestamp = 123456;
+      const timestamp = 123_456;
       const packageName = 'examplePackage';
       const packagePath = join(outputDirectory, packageName);
       $$.SANDBOX.stub(Date, 'now').returns(timestamp);