fix: handle string replacements for individual custom labels (#1257)

* fix: handle string replacements for individual custom labels * test: add nut to test single label replacement
forcedotcom · Mar 19, 2024 · 70571e8 · 70571e8
1 parent 570452a
commit 70571e8
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/convert/replacements.ts b/src/convert/replacements.ts
@@ -117,6 +117,12 @@ class ReplacementMarkingStream extends Transform {
     if (!chunk.isMarkedForDelete() && this.replacementConfigs?.length) {
       try {
         chunk.replacements = await getReplacements(chunk, this.replacementConfigs);
+        if (chunk.replacements && chunk.parent && chunk.type.name === 'CustomLabel') {
+          // Set replacements on the parent of a CustomLabel as well so that recomposing
+          // doesn't use the non-replaced content from parent cache.
+          // See RecompositionFinalizer.recompose() in convertContext.ts
+          chunk.parent.replacements = chunk.replacements;
+        }
       } catch (e) {
         if (!(e instanceof Error)) {
           throw e;

diff --git a/test/nuts/local/replacements/replacementsLabels.nut.ts b/test/nuts/local/replacements/replacementsLabels.nut.ts
@@ -71,14 +71,37 @@ describe('e2e replacements test (customLabels)', () => {
       await extractZip(zipBuffer, path.join(session.project.dir, 'unzipped'));
     });
 
-    it('label replacements as expected', async () => {
+    it('label replacements as expected (CustomLabels)', async () => {
       const labelsContents = await fs.promises.readFile(
         path.join(session.project.dir, 'unzipped', 'labels', 'CustomLabels.labels'),
         'utf8'
       );
       expect(labelsContents).to.not.include('original');
       expect(labelsContents).to.include('REPLACED_LABEL');
     });
+
+    it('label replacements as expected (CustomLabel)', async () => {
+      const converter = new MetadataConverter();
+      const cs = await ComponentSetBuilder.build({
+        metadata: {
+          metadataEntries: ['CustomLabel:Docs_CabinetId'],
+          directoryPaths: [path.join(session.project.dir, 'force-app')],
+        },
+      });
+      const { zipBuffer } = await converter.convert(cs, 'metadata', {
+        type: 'zip',
+      });
+      assert(zipBuffer, 'zipBuffer should be defined');
+      // extract zip files
+      await extractZip(zipBuffer, path.join(session.project.dir, 'unzipped2'));
+      const labelsContents = await fs.promises.readFile(
+        path.join(session.project.dir, 'unzipped2', 'labels', 'CustomLabels.labels'),
+        'utf8'
+      );
+      expect(labelsContents).to.not.include('original');
+      expect(labelsContents).to.include('REPLACED_LABEL');
+    });
+
     it('class replacements as expected', async () => {
       const classContents = await fs.promises.readFile(
         path.join(session.project.dir, 'unzipped', 'classes', 'replaceStuff.cls'),